[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openvz-devel
Subject:    [Devel] [PATCH rhel6 2/3] cpt: dump dentry alias path for UNIX socket
From:       vvs () virtuozzo ! com (Vasily Averin)
Date:       2015-09-28 16:24:23
Message-ID: 560969B7.3060504 () virtuozzo ! com
[Download RAW message or body]

On 28.09.2015 19:21, Stanislav Kinsburskiy wrote:
> 28.09.2015 17:57, Vasily Averin ?????:
> > Stas,
> > please see my comment below.
> > 
> > > --- a/include/linux/cpt_image.h
> > > +++ b/include/linux/cpt_image.h
> > > @@ -963,6 +963,11 @@ struct cpt_sock_image
> > > __u32    cpt_i_uid;
> > > __u32    cpt_i_gid;
> > > +
> > > +    __u32    cpt_d_alias[128/4];
> > > +
> > > +    __u32    cpt_d_aliaslen;
> > > +    __u32    __cpt_pad15;
> > > } __attribute__ ((aligned (8)));
> > size of this structure increases ==> CPT image version should be increased ==> \
> > it's impossible to migrate from new kernels to old ones. Am I missed something?
> 
> Frankly, yes.
> It's not necessary to change image version.
> There is a "cpd_object_has()" helper, allowing to check, whether
> image has additional fields at the end or not dynamically. IOW, old
> kernel won't notice these new fields and will proceed as before.
> It's used in third patch of the series.

Thank you for explanation!


[prev in list] [next in list] [prev in thread] [next in thread]