[prev in list] [next in list] [prev in thread] [next in thread]
List: openvz-devel
Subject: [Devel] Re: [PATCH v6 5/8] SUNRPC: cleanup service destruction
From: skinsbursky () parallels ! com (Stanislav Kinsbursky)
Date: 2011-10-28 9:49:12
Message-ID: 4EAA7A98.5070502 () parallels ! com
[Download RAW message or body]
28.10.2011 01:30, J. Bruce Fields ?????:
> On Tue, Oct 25, 2011 at 02:17:18PM +0300, Stanislav Kinsbursky wrote:
>> svc_unregister() call have to be removed from svc_destroy() since it will be
>> called in sv_shutdown callback.
>
> It would be clearer that you're *moving* this if this were merged with
> the following patch. And without doing that the series isn't quite
> bisectable, unless I'm missing something.
>
Yes, you are right. Will resend new version soon.
> --b.
>
>>
>> Signed-off-by: Stanislav Kinsbursky<skinsbursky at parallels.com>
>>
>> ---
>> net/sunrpc/svc.c | 1 -
>> 1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
>> index 918edc3..407462f 100644
>> --- a/net/sunrpc/svc.c
>> +++ b/net/sunrpc/svc.c
>> @@ -530,7 +530,6 @@ svc_destroy(struct svc_serv *serv)
>> if (svc_serv_is_pooled(serv))
>> svc_pool_map_put();
>>
>> - svc_unregister(serv);
>> kfree(serv->sv_pools);
>> kfree(serv);
>> }
>>
--
Best regards,
Stanislav Kinsbursky
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic