[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openvz-devel
Subject:    [Devel] Re: [PATCH RFC] powerpc: catch 32/64bit mix
From:       orenl () cs ! columbia ! edu (Oren Laadan)
Date:       2009-11-25 20:32:40
Message-ID: 4B0D9468.3050606 () cs ! columbia ! edu
[Download RAW message or body]



Serge E. Hallyn wrote:
> Quoting Oren Laadan (orenl at cs.columbia.edu):
>> I can't recall a convincing reason why restore_{thread,cpu}() should
>> run so late, or in particular after restore_task_objs().
>>
>> I think the original motivation was to avoid the point-of-no-return
>> at a very early stage. However this is only useful for self-restart.
>>
>> If we ever want self-restart to fail gracefully should something go
>> wrong, we should be prepared to undo any changes to the process -
>> on the error path. While not beyond reach, it isn't a top priority.
>>
>> Does calling restore_{thread,cpu}() earlier solve the problem ?
> 
> Yes, it does.
> 
>> BTW, this is also relevant for x86-64...
> 
> and also 31-bit s390

Excellent. Then I'll change the order for v19-rc2.

Thanks,

Oren.


_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers



[prev in list] [next in list] [prev in thread] [next in thread]