[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openvswitch-git
Subject:    [ovs-git] Open vSwitch: vport-internal: Set vport to NULL when detaching. (master)
From:       dev () openvswitch ! org (dev at openvswitch ! org)
Date:       2010-07-30 20:47:21
Message-ID: E1OewUD-000090-Jl () li27-103 ! members ! linode ! com
[Download RAW message or body]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  63db6ec35ddc2432dda059f277257886c2d1ba8f (commit)
       via  cc98976af50fec5643a372aa9c7a4c4e565e939e (commit)
       via  b4a7d61582ef3a09a666106a926c8912201dfe72 (commit)
      from  67c74f7515867fb8b3a4d23af98dacd3d547ebdd (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 63db6ec35ddc2432dda059f277257886c2d1ba8f
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=63db6ec35ddc2432dda059f277257886c2d1ba8f
                
Author: Jesse Gross <jesse at nicira.com>
		
vport-internal: Set vport to NULL when detaching.
		
'struct net_device' is refcounted and can stick around for quite a
while if someone is still holding a reference to it.  However, we
free the vport that it is attached to in the next RCU grace period
after detach.  This assigns the vport to NULL on detach and adds
appropriate checks.


commit cc98976af50fec5643a372aa9c7a4c4e565e939e
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=cc98976af50fec5643a372aa9c7a4c4e565e939e
                
Author: Jesse Gross <jesse at nicira.com>
		
vport: Make dp_port->vport always valid.
		
When we detached a vport we would assign NULL to dp_port->vport
before calling synchronize_rcu().  However, since vports have a
longer lifetime than dp_ports there were no checks before
dereferencing dp_port->vport.  This changes the behavior to
match the assumption by not assigning NULL during detach.  This
avoids a potential NULL pointer dereference in do_output() among
other places.


commit b4a7d61582ef3a09a666106a926c8912201dfe72
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=b4a7d61582ef3a09a666106a926c8912201dfe72
                
Author: Jesse Gross <jesse at nicira.com>
		
datapath: Remove dead code.
		
Several blocks of code were either no longer being called or had
been "#if 0"'d out for a long time.  This removes them.


-----------------------------------------------------------------------

Summary of changes:
 datapath/datapath.c           |    4 +-
 datapath/dp_notify.c          |    7 +-
 datapath/dp_sysfs_dp.c        |  238 +++++++++++------------------------------
 datapath/dp_sysfs_if.c        |   82 +--------------
 datapath/flow.c               |    5 -
 datapath/vport-internal_dev.c |   47 +++++----
 datapath/vport.c              |    5 -
 7 files changed, 95 insertions(+), 293 deletions(-)


hooks/post-receive
-- 
Open vSwitch


[prev in list] [next in list] [prev in thread] [next in thread]