[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openvswitch-discuss
Subject:    [ovs-discuss] resubmit action within a group bucket
From:       blp () nicira ! com (Ben Pfaff)
Date:       2014-08-27 19:37:36
Message-ID: 20140827193736.GA10430 () nicira ! com
[Download RAW message or body]

On Thu, Aug 21, 2014 at 02:43:52PM -0700, Srini Seetharaman wrote:
> > I suspect that "resubmit" should happen at the end, either before or
> > after "group" or "output" actions.
> 
> Since "resubmit" will provide another opportunity to add output action
> to the action-set, I would vote for having "resubmit" happen at the
> end of the action-set, rather than before.
> 
> I did a bit more code digging and noticed that the resubmit in group
> is not really disallowed. But, rather not taken seriously. Here is a
> patch that will fix that issue. I tested the resubmit action within
> the group with that patch, and it works! Can I submit this for
> upstream?
> 
> diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
> index ed30ec2..2ecca2a 100644
> --- a/lib/ofp-actions.c
> +++ b/lib/ofp-actions.c
> @@ -4481,7 +4481,8 @@ ofpacts_execute_action_set(struct ofpbuf *action_list,
>       * all the actions because there's no point in modifying a packet that will
>       * not be sent anywhere. */
>      if (!ofpacts_copy_last(action_list, action_set, OFPACT_GROUP) &&
> -        !ofpacts_copy_last(action_list, action_set, OFPACT_OUTPUT)) {
> +        !ofpacts_copy_last(action_list, action_set, OFPACT_OUTPUT) &&
> +        !ofpacts_copy_last(action_list, action_set, OFPACT_RESUBMIT)) {
>          ofpbuf_clear(action_list);
>      }
>  }

That seems reasonable.  Please submit it to ovs-dev according to the
procedure documented in CONTRIBUTING.

[prev in list] [next in list] [prev in thread] [next in thread]