[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openvswitch-discuss
Subject:    [ovs-discuss] [PATCH] ofproto/ofproto.c, lib/vconn.c:: OFPBRC_BAD_VERSION generated from switch when
From:       blp () nicira ! com (Ben Pfaff)
Date:       2012-06-28 15:24:11
Message-ID: 20120628152411.GC31147 () nicira ! com
[Download RAW message or body]

On Thu, Jun 28, 2012 at 06:16:06AM +0000, Amit Tewari wrote:
> As per our analysis and requirement we provided the patch for selected openflow \
> messages which carry useful data in data field for controller from switch. 
> Please confirm whether you have applied the patch we provided earlier?

No.  It doesn't make sense to add a special case for every message in
the middle of the code.  If we need to handle this at all, we should
handle it in a single place without duplicate special cases.

Also, your patch was against an old version of Open vSwitch.  We only
accept patches against the newest version.

> Please let me know if am missing any openflow message.

See, that's the problem.  You *can* miss some messages if you do it your
way.


[prev in list] [next in list] [prev in thread] [next in thread]