[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openvswitch-discuss
Subject:    [ovs-discuss] [PATCH] xenserver: Reduce number of xapi DB calls in plugin
From:       blp () nicira ! com (Ben Pfaff)
Date:       2011-11-30 16:27:08
Message-ID: 20111130162708.GQ2684 () nicira ! com
[Download RAW message or body]

On Tue, Nov 29, 2011 at 05:51:57PM +0000, Dominic Curran wrote:
> From: Rob Hoes <rob.hoes at citrix.com>
> Subject: [PATCH] xenserver: Reduce number of xapi DB calls in plugin
> 
> When there are lots of PIFs in a XenServer/XCP pool, for example when
> there are many VLANs configured on the pool, operations such as
> PIF.get_all and loops over all PIFs which include database operations,
> are very inefficient when executed on a pool slave, and should be
> avoided as much as possible. This patch reduces the number of database
> calls in the update function of the openvswitch-cfg-update xapi plugin.
> 
> Signed-off-by: Rob Hoes <rob.hoes at citrix.com>
> Ack-by: Dominic Curran <Dominic.curran at citrix.com>

Your patch seems reasonable but it's wordwrapped and won't apply.  Can
you send it with a MUA that does not wrap lines?  "git send-email" is
the easiest way.

Other minor points: The correct tag is "Acked-by" (not "Ack-by") and the
correct mailing list for patches is dev at openvswitch.org.

Thanks,

Ben.

[prev in list] [next in list] [prev in thread] [next in thread]