[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openvswitch-dev
Subject:    [ovs-dev] [PATCH v4 0/4] Support native dhcp in ovn controller
From:       russell () ovn ! org (Russell Bryant)
Date:       2016-03-31 21:06:29
Message-ID: CA+0q_PjYuJuJou9tMb=-LFzHU-oScayJd7mofK_r3zhHqebTBg () mail ! gmail ! com
[Download RAW message or body]

On Thu, Mar 31, 2016 at 11:48 AM, Ben Pfaff <blp at ovn.org> wrote:

> On Thu, Mar 31, 2016 at 09:07:38PM +0530, Numan Siddique wrote:
> > > I'm not sure if a src of 0.0.0.0 is a good idea.  Wouldn't that
> typically
> > > be the IP address of the DHCP server?  I'd be worried about some
> clients
> > > treating it as invalid.
> > >
> > > I think it should be specified by logical flows.  Something like:
> > >
> > >     dhcp_offer(offer_ip=10.0.0.3, netmask=255.255.255.0,
> > > mtu=1300, dns={8.8.8.8, 7.7.7.7}); eth.dst = eth.src; eth.src =
> > > <SOMETHING>; ip.src = <SOMETHING>; outport = inport; inport = "";
> output;
> > >
> > > As for what addresses to use ... I don't know.  I think it should be
> > > specified via OVN_Northbound, somehow.  It's easy enough for Neutron to
> > > generate an IP and MAC to use.  It already creates DHCP ports for this
> > > purpose.  Maybe it could just be additional logical port options, like
> > > you're doing for the rest of the DHCP parameters?
> > >
> > >
> > ​Thanks Russel for the comments.
> > Since most of the dhcp options are common to all the ports of ​a virtual
> > network, I was thinking may be it's good to add a new column -
> > 'dhcp_options' in Logical_Switch table. This can be used to store all the
> > dhcp options including the server ip and mac.
> >
> > ​We can still use Logical_Port.options to store extra dhcp options
> specific
> > to a port.​
>
> That seems reasonable to me.
>

Same here.  Thanks!

-- 
Russell Bryant

[prev in list] [next in list] [prev in thread] [next in thread]