[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openvswitch-dev
Subject:    [ovs-dev] tunnel logging
From:       blp () nicira ! com (Ben Pfaff)
Date:       2014-10-31 21:48:51
Message-ID: 20141031214851.GH13010 () nicira ! com
[Download RAW message or body]

Last year, commit 74a99109015a made the following change:

    tunnel: Log tunneling changes at INFO level.

    These log messages occur infrequently, and are quite useful when
    debugging problems after the fact.  So they should be logged at
    info level which makes them more readily available.

    Signed-off-by: Ethan Jackson <ethan at nicira.com>

but the actual code is really weird.  As you can see, it logs at INFO
level, but only if debug logging is enabled:

    if (VLOG_IS_DBG_ENABLED()) {
        struct ds ds = DS_EMPTY_INITIALIZER;

        tnl_match_fmt(&tnl_port->match, &ds);
        VLOG_INFO("%s tunnel port %s (%s)", action,
                  tnl_port_get_name(tnl_port), ds_cstr(&ds));
        ds_destroy(&ds);
    }

I guess that wasn't your intent?

[prev in list] [next in list] [prev in thread] [next in thread]