[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openvswitch-dev
Subject:    [ovs-dev] openvswitch_handle_frame_hook
From:       tgraf () redhat ! com (Thomas Graf)
Date:       2013-06-29 0:19:49
Message-ID: 51CE2825.6000108 () redhat ! com
[Download RAW message or body]

Jesse,

On 06/29/2013 12:44 AM, Jesse Gross wrote:
> Pravin pointed out that the RHEL6 openvswitch_handle_frame_hook
> unregister is happening from the RCU callback, which means that we
> immediately free the vport after removing the handler. This seems
> racy. I also noticed that we have asymmetric use of
> netdev_rx_handler_register/unregister (I don't think that this is an
> actual problem but it doesn't seem right). I think the ideal solution
> would be to put this and the code for kernels < 2.6.37 (which is very
> similar) into backports for netdev_rx_handler_register(). This would
> both hide the differences and ensure consistency.
>
> Can you take a look?

Makes sense. We will take a look and propose a fix. Thanks for
the pointer.

[prev in list] [next in list] [prev in thread] [next in thread]