[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openvswitch-dev
Subject:    [ovs-dev] [RFC v4 00/63] Preliminary Open Flow 1.2 Message	Support
From:       yamahata () valinux ! co ! jp (Isaku Yamahata)
Date:       2012-06-29 10:50:11
Message-ID: 20120629105011.GK2546 () valinux ! co ! jp
[Download RAW message or body]

On Fri, Jun 29, 2012 at 01:41:31PM +0900, Isaku Yamahata wrote:
> ../utilities/ovs-ofctl.c: In function 'do_show':
> ../utilities/ovs-ofctl.c:500:63: warning: 'vconn' is used uninitialized in this \
> function [-Wuninitialized]


The following local hack is necessary to make ovs-ofctl work.
At the moment, I'm not sure what version number should be sent at hello message.

diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c
index f26356e..087e8f1 100644
--- a/utilities/ovs-ofctl.c
+++ b/utilities/ovs-ofctl.c
@@ -497,7 +497,7 @@ do_show(int argc OVS_UNUSED, char *argv[])
     struct ofpbuf *reply;
     bool trunc;
 
-    make_openflow(sizeof(struct ofp_header), vconn_get_version(vconn),
+    make_openflow(sizeof(struct ofp_header), OFP12_VERSION,
                   OFPT_FEATURES_REQUEST, &request);
     open_vconn(vconn_name, &vconn);
 

-- 
yamahata


[prev in list] [next in list] [prev in thread] [next in thread]