[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openvswitch-dev
Subject:    [ovs-dev] [PATCH] stp: Log topology change events.
From:       ethan () nicira ! com (Ethan Jackson)
Date:       2012-01-28 5:46:56
Message-ID: CAEruU62T9F6TJU2Wf1qydKH3dWnT2veQvBArcM0Q8hJPbaLGnQ () mail ! gmail ! com
[Download RAW message or body]

> I think it would be more better for test-stp.c to just call
> vlog_set_pattern() itself, rather than each use of it including it on
> the command line. ?You could also have it disable logging to syslog
> with vlog_set_levels(), since that just makes the unit tests spam
> syslog. ?If you make those changes, then test-stp.c wouldn't need the
> more sophisticated command-line parsing that you added; I am
> indifferent whether you keep it or remove it.

I'm not sure I agree.  It seems better to me to implement the full
fledged solution giving the automake tests full control how the
logging should look.  It seems less adhoc and more future proof to me.
 That said, it's testing code and doesn't really matter.  I'll go
ahead and change it.

Ethan


[prev in list] [next in list] [prev in thread] [next in thread]