[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openvswitch-dev
Subject:    [ovs-dev] [PATCH 2/3] netdev-linux: Fix off-by-one error dumping queue stats.
From:       jpettit () nicira ! com (Justin Pettit)
Date:       2010-09-30 5:39:30
Message-ID: B160718B-FF12-4940-BC48-E77BF0DB5860 () nicira ! com
[Download RAW message or body]

I'll take your word for it.  :-)

--Justin


On Sep 16, 2010, at 3:42 PM, Ben Pfaff wrote:

> Linux kernel queue numbers are one greater than OpenFlow queue numbers, for
> HTB anyhow.  The code to dump queues wasn't compensating for this, so this
> commit fixes it up.
> ---
> lib/netdev-linux.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
> index e6036bf..f2afc35 100644
> --- a/lib/netdev-linux.c
> +++ b/lib/netdev-linux.c
> @@ -2621,7 +2621,7 @@ htb_class_dump_stats(const struct netdev *netdev OVS_UNUSED,
>     major = tc_get_major(handle);
>     minor = tc_get_minor(handle);
>     if (major == 1 && minor > 0 && minor <= HTB_N_QUEUES) {
> -        (*cb)(tc_get_minor(handle), &stats, aux);
> +        (*cb)(minor - 1, &stats, aux);
>     }
>     return 0;
> }
> -- 
> 1.7.1
> 
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev_openvswitch.org




[prev in list] [next in list] [prev in thread] [next in thread]