[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openvswitch-dev
Subject:    [ovs-dev] [PATCH 1/2] debian: Create ovs-monitor-ipsec rundir if it doesn't exist
From:       jpettit () nicira ! com (Justin Pettit)
Date:       2010-09-28 19:03:20
Message-ID: 79BFEE36-F159-4DD9-A09B-BA33126182B8 () nicira ! com
[Download RAW message or body]

Ben and Romain,

Thanks for the discussion on directory creation in Debian packaging.  Based on Ben's \
comments, I pushed the patch series as-is.

--Justin


On Sep 28, 2010, at 10:40 AM, Ben Pfaff wrote:

> I'm not sure that that is safe.  The Filesystem Hierarchy Standard says
> about /var/run that "Files under this directory must be cleared (removed
> or truncated as appropriate) at the beginning of the boot process."
> This might be interpreted as license to remove directories too.  It
> doesn't look like Debian does that, but /lib/init/bootclean.sh does have
> a reference to mounting /var/run as tmpfs, in which case
> /var/run/openvswitch would need to be recreated on every boot.
> 
> On Tue, Sep 28, 2010 at 11:19:02AM +0900, Romain Lenglet wrote:
> > Hi Justin,
> > Why not simply add var/run/openvswitch into debian/openvswitch-ipsec.dirs?
> > 
> > On Tue, Sep 28, 2010 at 10:56 AM, Justin Pettit <jpettit at nicira.com> wrote:
> > 
> > > Reported-by: Sajjad Lateef <slateef at nicira.com>
> > > ---
> > > debian/openvswitch-ipsec.init |    4 ++++
> > > 1 files changed, 4 insertions(+), 0 deletions(-)
> > > 
> > > diff --git a/debian/openvswitch-ipsec.init b/debian/openvswitch-ipsec.init
> > > index 5f42406..ba82f51 100755
> > > --- a/debian/openvswitch-ipsec.init
> > > +++ b/debian/openvswitch-ipsec.init
> > > @@ -69,6 +69,10 @@ running() {
> > > }
> > > 
> > > start_server() {
> > > +    if [ ! -d /var/run/openvswitch ]; then
> > > +        install -d -m 755 -o root -g root /var/run/openvswitch
> > > +    fi
> > > +
> > > PYTHONPATH=/usr/share/openvswitch/python \
> > > /usr/share/openvswitch/scripts/ovs-monitor-ipsec \
> > > --pidfile-name=$PIDFILE --detach --monitor \
> > > --
> > > 1.7.1
> > > 
> > > 
> > > _______________________________________________
> > > dev mailing list
> > > dev at openvswitch.org
> > > http://openvswitch.org/mailman/listinfo/dev_openvswitch.org
> > > 
> 
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev_openvswitch.org
> 


[prev in list] [next in list] [prev in thread] [next in thread]