[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openvswitch-dev
Subject:    [ovs-dev] [PATCH] ovs-ofctl: Add support for OpenFlow enqueue action.
From:       blp () nicira ! com (Ben Pfaff)
Date:       2010-07-30 23:06:24
Message-ID: 20100730230624.GK409 () nicira ! com
[Download RAW message or body]

On Fri, Jul 30, 2010 at 03:49:10PM -0700, Jesse Gross wrote:
> On Fri, Jul 30, 2010 at 3:40 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
> > On Fri, Jul 30, 2010 at 03:37:02PM -0700, Jesse Gross wrote:
> > > On Fri, Jul 30, 2010 at 10:40 AM, Ben Pfaff <blp at nicira.com> wrote:
> > > >
> > > > +        } else if (!strcasecmp(act, "enqueue")) {
> > > > +            char *sp = NULL;
> > > > +            char *port = strtok_r(arg, ":q", &sp);
> > > >
> > >
> > > Shouldn't the delimiter be just ":"?
> >
> > I thought I would also allow 'q' since that's the delimiter that
> > ofp-print uses for printing enqueue actions.  Or I could change
> > ofp-print just to use ':'.  What do you prefer?
> 
> The 'q' is fine, I just wasn't expecting it since it is left undocumented
> (which is also fine).

It kind of looks like I was using "vi" and didn't exit quite right,
doesn't it?  (But I don't use vi to edit code.)

Thanks.

I pushed this out.



[prev in list] [next in list] [prev in thread] [next in thread]