[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openvswitch-dev
Subject:    [ovs-dev] [PATCH] netdev-linux: Zero feature flags on error.
From:       blp () nicira ! com (Ben Pfaff)
Date:       2009-11-19 21:33:40
Message-ID: 87ocmyi4i3.fsf () blp ! benpfaff ! org
[Download RAW message or body]

Jesse Gross <jesse at nicira.com> writes:

> Ben Pfaff wrote:
>> Jesse Gross <jesse at nicira.com> writes:
>>
>>   
>>> We claimed that if we got an error when retrieving the features
>>> for an interface we would zero out all the flags.  We weren't
>>> doing this, which lead to random data for pseudo-devices.
>>>     
>>
>> I think it would be better to do this in netdev.c, like so:
>>
>>   
>
> OK, that looks fine.

Thanks, pushed.



[prev in list] [next in list] [prev in thread] [next in thread]