[prev in list] [next in list] [prev in thread] [next in thread]
List: openvpn-devel
Subject: [Openvpn-devel] [S] Change in openvpn[master]: Remove TEST_GET_DEFAULT_GATEWAY as it duplicates --sh
From: "plaisthos (Code Review)" <gerrit () openvpn ! net>
Date: 2023-11-30 16:24:38
Message-ID: 0768d158f9982da5613e353a86618e05d8cf656c-HTML () gerrit ! openvpn ! net
[Download RAW message or body]
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/463?usp=email
to review the following change.
Change subject: Remove TEST_GET_DEFAULT_GATEWAY as it duplicates --show-gateway
......................................................................
Remove TEST_GET_DEFAULT_GATEWAY as it duplicates --show-gateway
This debug code is not very useful as it is outdated and the same
functionality is provided by --show-gateway
Change-Id: Ie7fd59cc84e2eb024086c28c2ec2a5606a2b2e7c
Signed-off-by: Arne Schwabe <arne@rfc2549.org>
---
M src/openvpn/init.c
1 file changed, 0 insertions(+), 11 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/63/463/1
diff --git a/src/openvpn/init.c b/src/openvpn/init.c
index abba748..fdab26b 100644
--- a/src/openvpn/init.c
+++ b/src/openvpn/init.c
@@ -885,17 +885,6 @@
return false;
#endif
-#ifdef TEST_GET_DEFAULT_GATEWAY
- {
- struct route_gateway_info rgi;
- struct route_ipv6_gateway_info rgi6;
- get_default_gateway(&rgi);
- get_default_gateway_ipv6(&rgi6, NULL);
- print_default_gateway(M_INFO, &rgi, &rgi6);
- return false;
- }
-#endif
-
#ifdef GEN_PATH_TEST
{
struct gc_arena gc = gc_new();
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/463?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie7fd59cc84e2eb024086c28c2ec2a5606a2b2e7c
Gerrit-Change-Number: 463
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <arne-openvpn@rfc2549.org>
Gerrit-Reviewer: flichtenheld <frank@lichtenheld.com>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: flichtenheld <frank@lichtenheld.com>
Gerrit-MessageType: newchange
[Attachment #3 (text/html)]
<p> Attention is currently required from: flichtenheld. </p>
<p>plaisthos would like flichtenheld to <strong>review</strong> this change.
</p><p><a href="http://gerrit.openvpn.net/c/openvpn/+/463?usp=email">View \
Change</a></p><pre style="font-family: monospace,monospace; white-space: \
pre-wrap;">Remove TEST_GET_DEFAULT_GATEWAY as it duplicates \
--show-gateway<br><br>This debug code is not very useful as it is outdated and the \
same<br>functionality is provided by --show-gateway<br><br>Change-Id: \
Ie7fd59cc84e2eb024086c28c2ec2a5606a2b2e7c<br>Signed-off-by: Arne Schwabe \
<arne@rfc2549.org><br>---<br>M src/openvpn/init.c<br>1 file changed, 0 \
insertions(+), 11 deletions(-)<br><br></pre><pre style="font-family: \
monospace,monospace; white-space: pre-wrap;">git pull \
ssh://gerrit.openvpn.net:29418/openvpn refs/changes/63/463/1</pre><pre \
style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git \
a/src/openvpn/init.c b/src/openvpn/init.c</span><br><span>index abba748..fdab26b \
100644</span><br><span>--- a/src/openvpn/init.c</span><br><span>+++ \
b/src/openvpn/init.c</span><br><span>@@ -885,17 +885,6 @@</span><br><span> return \
false;</span><br><span> #endif</span><br><span> </span><br><span style="color: hsl(0, \
100%, 40%);">-#ifdef TEST_GET_DEFAULT_GATEWAY</span><br><span style="color: hsl(0, \
100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- struct \
route_gateway_info rgi;</span><br><span style="color: hsl(0, 100%, 40%);">- \
struct route_ipv6_gateway_info rgi6;</span><br><span style="color: hsl(0, 100%, \
40%);">- get_default_gateway(&rgi);</span><br><span style="color: hsl(0, \
100%, 40%);">- get_default_gateway_ipv6(&rgi6, NULL);</span><br><span \
style="color: hsl(0, 100%, 40%);">- print_default_gateway(M_INFO, &rgi, \
&rgi6);</span><br><span style="color: hsl(0, 100%, 40%);">- return \
false;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span \
style="color: hsl(0, 100%, 40%);">-#endif</span><br><span style="color: hsl(0, 100%, \
40%);">-</span><br><span> #ifdef GEN_PATH_TEST</span><br><span> \
{</span><br><span> struct gc_arena gc = \
gc_new();</span><br><span></span><br></pre><p>To view, visit <a \
href="http://gerrit.openvpn.net/c/openvpn/+/463?usp=email">change 463</a>. To \
unsubscribe, or for help writing mail filters, visit <a \
href="http://gerrit.openvpn.net/settings">settings</a>.</p><div itemscope \
itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" \
itemtype="http://schema.org/ViewAction"><link itemprop="url" \
href="http://gerrit.openvpn.net/c/openvpn/+/463?usp=email"/><meta itemprop="name" \
content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: openvpn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: \
Ie7fd59cc84e2eb024086c28c2ec2a5606a2b2e7c </div> <div style="display:none"> \
Gerrit-Change-Number: 463 </div> <div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: plaisthos <arne-openvpn@rfc2549.org> \
</div> <div style="display:none"> Gerrit-Reviewer: flichtenheld \
<frank@lichtenheld.com> </div> <div style="display:none"> Gerrit-CC: \
openvpn-devel <openvpn-devel@lists.sourceforge.net> </div> <div \
style="display:none"> Gerrit-Attention: flichtenheld <frank@lichtenheld.com> \
</div> <div style="display:none"> Gerrit-MessageType: newchange </div>
[Attachment #4 (--===============0239974627211786892==)]
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic