[prev in list] [next in list] [prev in thread] [next in thread]
List: openvpn-devel
Subject: [Openvpn-devel] [PATCH] Remove superfluous x509_write_pem()
From: David Sommerseth <dazo+openvpn () eurephia ! org>
Date: 2023-11-22 19:01:25
Message-ID: 20231122190125.120500-1-dazo+openvpn () eurephia ! org
[Download RAW message or body]
From: David Sommerseth <davids@openvpn.net>
After removing --tls-export-cert, this function was left in the code
base with no other users. This was an oversight in the previous
change. Removing it to avoid leaving dead code behind.
Signed-off-by: David Sommerseth <davids@openvpn.net>
---
src/openvpn/ssl_verify_backend.h | 11 -----------
src/openvpn/ssl_verify_mbedtls.c | 7 -------
src/openvpn/ssl_verify_openssl.c | 11 -----------
3 files changed, 29 deletions(-)
diff --git a/src/openvpn/ssl_verify_backend.h b/src/openvpn/ssl_verify_backend.h
index 3b798811..d402b1f2 100644
--- a/src/openvpn/ssl_verify_backend.h
+++ b/src/openvpn/ssl_verify_backend.h
@@ -249,17 +249,6 @@ result_t x509_verify_cert_ku(openvpn_x509_cert_t *x509, const unsigned *const ex
*/
result_t x509_verify_cert_eku(openvpn_x509_cert_t *x509, const char *const expected_oid);
-/*
- * Store the given certificate in pem format in a temporary file in tmp_dir
- *
- * @param cert Certificate to store
- * @param tmp_dir Temporary directory to store the directory
- * @param gc gc_arena to store temporary objects in
- *
- *
- */
-result_t x509_write_pem(FILE *peercert_file, openvpn_x509_cert_t *peercert);
-
/**
* Return true iff a CRL is configured, but is not loaded. This can be caused
* by e.g. a CRL parsing error, a missing CRL file or CRL file permission
diff --git a/src/openvpn/ssl_verify_mbedtls.c b/src/openvpn/ssl_verify_mbedtls.c
index a1ddf8d0..4596843c 100644
--- a/src/openvpn/ssl_verify_mbedtls.c
+++ b/src/openvpn/ssl_verify_mbedtls.c
@@ -547,13 +547,6 @@ x509_verify_cert_eku(mbedtls_x509_crt *cert, const char *const expected_oid)
return fFound;
}
-result_t
-x509_write_pem(FILE *peercert_file, mbedtls_x509_crt *peercert)
-{
- msg(M_WARN, "mbed TLS does not support writing peer certificate in PEM format");
- return FAILURE;
-}
-
bool
tls_verify_crl_missing(const struct tls_options *opt)
{
diff --git a/src/openvpn/ssl_verify_openssl.c b/src/openvpn/ssl_verify_openssl.c
index 3194c232..5afffc1f 100644
--- a/src/openvpn/ssl_verify_openssl.c
+++ b/src/openvpn/ssl_verify_openssl.c
@@ -762,17 +762,6 @@ x509_verify_cert_eku(X509 *x509, const char *const expected_oid)
return fFound;
}
-result_t
-x509_write_pem(FILE *peercert_file, X509 *peercert)
-{
- if (PEM_write_X509(peercert_file, peercert) < 0)
- {
- msg(M_NONFATAL, "Failed to write peer certificate in PEM format");
- return FAILURE;
- }
- return SUCCESS;
-}
-
bool
tls_verify_crl_missing(const struct tls_options *opt)
{
--
2.39.3
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic