[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openvpn-devel
Subject:    [Openvpn-devel] [M] Change in openvpn[master]: dev-tools/gerrit-send-mail.py: tool to send Gerrit pa
From:       "flichtenheld (Code Review)" <gerrit () openvpn ! net>
Date:       2023-09-26 10:37:52
Message-ID: 48f7211ffb8b787a50f7998ab04a95035e3578a0-EmailReviewComments-HTML () gerrit ! openvpn ! net
[Download RAW message or body]

Attention is currently required from: cron2, d12fk.

flichtenheld has posted comments on this change. ( \
http://gerrit.openvpn.net/c/openvpn/+/361?usp=email )

Change subject: dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to \
                Patchwork
......................................................................


Patch Set 4:

(1 comment)

File dev-tools/gerrit-send-mail.py:

http://gerrit.openvpn.net/c/openvpn/+/361/comment/6568c48d_82c7d5d0 :
PS3, Line 47:                 ack = "{} <{}>".format(reviewer.get("display_name", \
reviewer["name"]), reviewer.get("email", reviewer["name"]))
> I would be in favor of f-string everywhere, they are just so much easier to read \
> and actually faster […]
Done



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/361?usp=email
To unsubscribe, or for help writing mail filters, visit \
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: If4e9c2e58441efb3fd00872cd62d1cc6c607f160
Gerrit-Change-Number: 361
Gerrit-PatchSet: 4
Gerrit-Owner: flichtenheld <frank@lichtenheld.com>
Gerrit-Reviewer: cron2 <gert@greenie.muc.de>
Gerrit-CC: d12fk <heiko@openvpn.net>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: cron2 <gert@greenie.muc.de>
Gerrit-Attention: d12fk <heiko@openvpn.net>
Gerrit-Comment-Date: Tue, 26 Sep 2023 10:37:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: d12fk <heiko@openvpn.net>
Gerrit-MessageType: comment


[Attachment #3 (text/html)]

<p> Attention is currently required from: cron2, d12fk. </p>
<p><a href="http://gerrit.openvpn.net/c/openvpn/+/361?usp=email">View \
Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li \
style="margin: 0; padding: 0;"><p>File dev-tools/gerrit-send-mail.py:</p><ul \
style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p \
style="margin-bottom: 4px;"><a \
href="http://gerrit.openvpn.net/c/openvpn/+/361/comment/6568c48d_82c7d5d0">Patch Set \
#3, Line 47:</a> <code style="font-family:monospace,monospace">                ack = \
&quot;{} &lt;{}&gt;&quot;.format(reviewer.get(&quot;display_name&quot;, \
reviewer[&quot;name&quot;]), reviewer.get(&quot;email&quot;, \
reviewer[&quot;name&quot;]))</code></p><p><blockquote style="border-left: 1px solid \
#aaa; margin: 10px 0; padding: 0 10px;">I would be in favor of f-string everywhere, \
they are just so much easier to read and actually faster […]</blockquote></p><p \
style="white-space: pre-wrap; word-wrap: \
break-word;">Done</p></li></ul></li></ul><p>To view, visit <a \
href="http://gerrit.openvpn.net/c/openvpn/+/361?usp=email">change 361</a>. To \
unsubscribe, or for help writing mail filters, visit <a \
href="http://gerrit.openvpn.net/settings">settings</a>.</p><div itemscope \
itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" \
itemtype="http://schema.org/ViewAction"><link itemprop="url" \
href="http://gerrit.openvpn.net/c/openvpn/+/361?usp=email"/><meta itemprop="name" \
content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: openvpn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: \
If4e9c2e58441efb3fd00872cd62d1cc6c607f160 </div> <div style="display:none"> \
Gerrit-Change-Number: 361 </div> <div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: flichtenheld &lt;frank@lichtenheld.com&gt; \
</div> <div style="display:none"> Gerrit-Reviewer: cron2 &lt;gert@greenie.muc.de&gt; \
</div> <div style="display:none"> Gerrit-CC: d12fk &lt;heiko@openvpn.net&gt; </div>
<div style="display:none"> Gerrit-CC: openvpn-devel \
&lt;openvpn-devel@lists.sourceforge.net&gt; </div> <div style="display:none"> \
Gerrit-Attention: cron2 &lt;gert@greenie.muc.de&gt; </div> <div style="display:none"> \
Gerrit-Attention: d12fk &lt;heiko@openvpn.net&gt; </div> <div style="display:none"> \
Gerrit-Comment-Date: Tue, 26 Sep 2023 10:37:52 +0000 </div> <div \
style="display:none"> Gerrit-HasComments: Yes </div> <div style="display:none"> \
Gerrit-Has-Labels: No </div> <div style="display:none"> Comment-In-Reply-To: d12fk \
&lt;heiko@openvpn.net&gt; </div> <div style="display:none"> Gerrit-MessageType: \
comment </div>


[Attachment #4 (--===============8928452929525876853==)]


_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel


[prev in list] [next in list] [prev in thread] [next in thread]