[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openvpn-devel
Subject:    [Openvpn-devel] [PATCH applied] Re: Option --cryptoapicert: support issuer name as a selector
From:       Gert Doering <gert () greenie ! muc ! de>
Date:       2023-02-14 15:36:05
Message-ID: 202302141536.31EFa5uj025063 () chekov ! greenie ! muc ! de
[Download RAW message or body]

Acked-by: Gert Doering <gert@greenie.muc.de>

I did hope that someone else would report back and say "I have tested this
and it works great!".  Nobody volunteered and I wanted this out of the
way (and I think it's a useful addition with very little code needed).

Code looks good according to documentation of CertFindCertificateInStore()
(though the microsoft documentation I found lacks the CERT_FIND...*_W
defines... but it's symmetric to CERT_FIND_SUBJECT_STR_W)

MinGW and GH tell me that the code compiles fine :-)

Documentation addition is good and well-understandable.

Your patch has been applied to the master and release/2.6 branch.

commit b9e0e4060798ed88d2170702f2935754616b1200 (master)
commit a8ff15ce49b69816b64387e3387b9a310891d12a (release/2.6)
Author: Selva Nair
Date:   Sat Jan 28 17:34:18 2023 -0500

     Option --cryptoapicert: support issuer name as a selector

     Signed-off-by: Selva Nair <selva.nair@gmail.com>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Message-Id: <20230128223421.2207802-2-selva.nair@gmail.com>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26092.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[prev in list] [next in list] [prev in thread] [next in thread]