[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openvpn-devel
Subject:    Re: [Openvpn-devel] [PATCH v5 2/3] Allow setting control channel packet size with max-packet-size
From:       tincantech via Openvpn-devel <openvpn-devel () lists ! sourceforge ! net>
Date:       2022-10-20 11:13:59
Message-ID: hOhG8Yh9IXDeY0BXWdi5KuJXs7V7ztwMpGSOHL_XdTN6cb4igtiCNQaOrv61xopCO0mNn-kHRRSMdLmwwUbRJQNBZ82W1-ljYnXo6ocihK8= () protonmail ! com
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi,

Plus one more typo.

Sent with Proton Mail secure email.

------- Original Message -------
On Thursday, October 20th, 2022 at 11:05, Arne Schwabe <arne@rfc2549.org> wrote:

<snip>

> diff --git a/src/openvpn/common.h b/src/openvpn/common.h
> index b94680885..dce6fd01d 100644
> --- a/src/openvpn/common.h
> +++ b/src/openvpn/common.h
> @@ -68,6 +68,19 @@ typedef unsigned long ptr_type;
> /
> #define TLS_CHANNEL_BUF_SIZE 2048
> 
> +/ TLS control buffer minimum size. This size is not actually inherent to
> + * the OpenVPN protocol. But with our current sending window being 6 and the
> + * receive window being 8 or 12 depending on the OpenVPN version, the biggest
> + * payload we can send is 6 * min_size. And we need to support to send payloads
> + * of TLS_CHANNEL_BUF_SIZE. Splitting this into more than
> + * 6 packets (with overhead) would complicate our sending logic a lot more.
> + * Diving TLS_CHANNEL_BUF_SIZE (2048) by 6 gets us ~342 byte. Allowing for

Diving -> Dividing

> + * ~100 bytes of overhead (in OpenVPN headers + IP headers) and rounding
> + * up to the next "nice" number gives use 512.
> + *
> + * /

-----BEGIN PGP SIGNATURE-----
Version: ProtonMail

wsBzBAEBCAAGBQJjUS1fACEJEE+XnPZrkLidFiEECbw9RGejjXJ5xVVVT5ec
9muQuJ2mxAf/afXklJAMoPqLoelxi8mF7hq97b3Eky6iB+zqiGXhOxBjVOKC
F6BpNk2uxCUkNSU9FPaLDTMurKuGe6p5+YSdHQh13EzZkx/vehBce4/+OWZ5
nInvafaUbtAI0LqHZvcNhjB2LQcci2MUyw6duok1V43LRdYFZ0ohk4/o+HZ7
6vrij4xNLO1BHhc91CKS0Gm9ZierXPHS8vmAc6ssrhhhq8eFetVq58S7dhyQ
ISx8xg20MnqjynmDjpOVgbxKW00+OBTK5NWGLEXd5effQjgdz4qEv5MBoS4V
sNdvCBw4tU/GrZdYlBihcQf2h6tgGJ0DxEu4qiF0Tg1h81rrEHSahw==
=8tPU
-----END PGP SIGNATURE-----

["publickey - tincantech@protonmail.com - 0x09BC3D44.asc" (application/pgp-keys)]
["publickey - tincantech@protonmail.com - 0x09BC3D44.asc.sig" (application/pgp-signature)]



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel


[prev in list] [next in list] [prev in thread] [next in thread]