[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openvpn-devel
Subject:    Re: [Openvpn-devel] [PATCH v2] Fix console prompts with redirected log
From:       Gert Doering <gert () greenie ! muc ! de>
Date:       2021-06-24 15:34:01
Message-ID: 20210624153401.GJ976 () greenie ! muc ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Hi,

On Thu, Jun 24, 2021 at 11:39:18AM +0300, Lev Stipakov wrote:
> From: Lev Stipakov <lev@openvpn.net>
> 
> When openvpn nees to prompt user for a password
> (for example, to set management interface password),
> the prompt is written to standard error device.
> 
> When log is redirected to a file, that prompt is written
> to that file and not to the "original" stderr. Moreover, on recent
> Insider build (21390.2025) openvpn exits with fatal error
> 
>   get_console_input_win32(): unexpected error: No such device or address (errno=6)

Feature-ACK, and tested your binary, which works nicely.

Can you rebase this on top of master?  I wanted my "improve error logging"
patch in the tree, and of course it conflicts big time.

While I could fix these, I think having a v3 that applies nicely would
be a cleaner approach...

thanks,

gert
-- 
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             gert@greenie.muc.de

["signature.asc" (application/pgp-signature)]



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel


[prev in list] [next in list] [prev in thread] [next in thread]