[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openvpn-devel
Subject:    Re: [Openvpn-devel] [PATCH v2] Implement '--compress migrate' to migrate to non-compression setup
From:       Gert Doering <gert () greenie ! muc ! de>
Date:       2021-03-28 10:41:39
Message-ID: 20210328104139.GC976 () greenie ! muc ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Hi,

On Thu, Mar 25, 2021 at 09:13:13PM +0100, Antonio Quartulli wrote:
[..]
> Acked-by: Antonio Quartulli <antonio@openvpn.net>

I see your ACK, and find myself wanting to be convinced that this is
really the best possible approach.

The code change in multi.c is nice, but the effects on ssl.c are ugly,
and will be with us "forever".

So I wonder if un-rushing the part about "make compression go away" 
slightly (since even with "comp-lzo set", both ends do not actually 
compress anymore, already today), and rushing "remove all/most OCC 
warnings" instead (including 2.5.x) - so, when 2.5.x and 2.6.x just 
do not warn on OCC mismatches anymore, we could have the nice part of 
this patch, and skip the ugly one.

For everything that can be pushed, OCC warnings seem to just get in the
way these days.


I'm not adamant on this, just want a bit more discussion on "best strategy"
and timeline.  I've put it on wednesday's meeting agenda - more brains
around, then :-)

gert
-- 
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             gert@greenie.muc.de

["signature.asc" (application/pgp-signature)]



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel


[prev in list] [next in list] [prev in thread] [next in thread]