[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openvpn-devel
Subject:    Re: [Openvpn-devel] [PATCH 2/5] xmit_hold is only required for port_share
From:       Arne Schwabe <arne () rfc2549 ! org>
Date:       2020-10-26 9:49:12
Message-ID: c0f890fb-bd6c-1e76-7316-590c95bfb34e () rfc2549 ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


Am 24.10.20 um 21:43 schrieb Gert Doering:
> Hi,
> 
> On Fri, Oct 23, 2020 at 01:34:28PM +0200, Arne Schwabe wrote:
>> Make options.c only set xmit_hold when port_share is active to least
>> document this dependency. I have not actually tested if this dependency
>> is actually true (or if port_share could work without xmit_hold).
> 
> I'm not sure I understand this patch, or the flow.  Before this patch,
> xmit_hold is always set to "true" for TCP_SERVER, after this patch,
> only for server *and* port_share.
> 
> What am I overlooking?
> 

No. This feature was introduced as part of port-share and I am not even
sure it is really required for port-share. Normally we do not send
anything unless there is a valid OpenVPN RESET packet. So I want to
limit it again to part-share before I can really reliable say that even
port-share doesn't need it.

Arne



["signature.asc" (application/pgp-signature)]



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel


[prev in list] [next in list] [prev in thread] [next in thread]