[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openvpn-devel
Subject:    Re: [Openvpn-devel] [PATCH 1/7] tun.c: make Windows device lookup functions more general
From:       Gert Doering <gert () greenie ! muc ! de>
Date:       2019-12-20 13:49:19
Message-ID: 20191220134919.GL74723 () greenie ! muc ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Hi,

On Thu, Dec 19, 2019 at 11:39:11PM +0100, Simon Rozman wrote:
> Since the introduction of Wintun, not all network devices in Windows are
> TAP-Windows6. Rather than returning a simple true/false answer, a couple
> of functions were reworked to return a corresponding struct tap_reg *
> or NULL instead.
> 
> As it would make the code `tr = is_tap_win(...)` a bit awkward those
> functions (both static) were renamed to better reflect their nature.

For the sake of the archives:  Simon and Lev discussed these patches
on IRC today, came up with proposed changes, and Simon will send a new
"v2" series of all of them - so even if they have an ACK, I won't
apply them just yet.

Just to avoid confusion.

gert
-- 
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             gert@greenie.muc.de

["signature.asc" (application/pgp-signature)]



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel


[prev in list] [next in list] [prev in thread] [next in thread]