[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openvpn-devel
Subject:    Re: [Openvpn-devel] [PATCH v2] ssl_verify: define label only when required
From:       Gert Doering <gert () greenie ! muc ! de>
Date:       2018-08-16 21:33:46
Message-ID: 20180816213346.GW74536 () greenie ! muc ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Hi,

thanks for your thoughts so far, so it seems we just want to get rid
of these conditionals for 2.5 :-)

One thing, though:

On Thu, Aug 16, 2018 at 10:28:05PM +0200, David Sommerseth wrote:
> There is also a related ./configure option: --enable-async-push.  This adds
> inotify support, which reworks the polling model to be a notification based
> push model instead (iirc).  But this I think makes sense to have as it is
> today for the time being.  We might want to consider flipping it to be enabled
> by default, though.

This carries along some platform dependencies, as "inotify" is not
unversally available (I was about to write "Linux only", but I bet 
one of the BSDs has it, too, by now :-) - but definitely not all 
supported platforms).

Google points to "fswatch", which is

 "A cross-platform file change monitor with multiple backends: Apple OS X 
  File System Events, *BSD kqueue, Solaris/Illumos File Events Notification, 
  Linux inotify, ..."

so yeah - this has to stay an #ifdef for a while (and more esoteric
platforms like *cough* Windows or AIX might not have anything reasonably
compatible at all)

gert
-- 
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             gert@greenie.muc.de

["signature.asc" (application/pgp-signature)]

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel


[prev in list] [next in list] [prev in thread] [next in thread]