[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openvpn-devel
Subject:    Re: [Openvpn-devel] [PATCH v2] Clarify and expand management interface documentation
From:       Selva Nair <selva.nair () gmail ! com>
Date:       2018-08-08 17:00:17
Message-ID: CAKuzo_jt8v==cr4PtNdqpVQar-4Jn3CAWKmEzZuWoxMPUvRu7g () mail ! gmail ! com
[Download RAW message or body]

Hi,

Thanks for the v2.

On Wed, Aug 8, 2018 at 7:35 AM, Jonathan K. Bullard via Openvpn-devel
<openvpn-devel@lists.sourceforge.net> wrote:
> Clarify and expand the documentation for the management interface:
>
> * Add examples of static and dynamic challenge/response sequences in
> the "COMMAND -- password and username" section.
>
> * Expand the "Challenge/Response" section with more detail.
>
> * Use "management interface client" throughout (instead of "management
> client", which was used in several places previously).
>
> * Clarify when both a username and password are needed, not just a
> username or a password.
>
> * Clarify that an exit with a fatal error for a dynamic C/R will occur
> only if "--auth-retry none" (the default) is in effect.
>
> * Fix a typo. ("posesses" => "possesses").
>
> Signed-off-by: Jonathan K. Bullard <jkbullard@gmail.com>
> ---
> v2:
>  * Incorporate Selva Nair's suggestions (thanks!).
>  * Remove incorrect quotes in Example 8.
>  * Use "base 64" throughout instead of "base64".
>
>  doc/management-notes.txt | 232 ++++++++++++++++++++++++++++++++---------------
>  1 file changed, 159 insertions(+), 73 deletions(-)

Looks good now.

The typo pointed out by tincanteksup is not a fault of this patch
but this may be a good time to fix it -- could be done at merge time?

On line 143 of doc/management-notes.txt after applying this patch:

managment --> management

Acked-by: selva.nair@gmail.com

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[prev in list] [next in list] [prev in thread] [next in thread]