[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openvas-cvs
Subject:    [Openvas-commits] r24261 - in trunk/gsa: . src
From:       scm-commit () wald ! intevation ! org
Date:       2016-01-31 12:21:22
Message-ID: 20160131122122.5B4D190024F3 () wald ! intevation ! org
[Download RAW message or body]

Author: mattm
Date: 2016-01-31 13:21:22 +0100 (Sun, 31 Jan 2016)
New Revision: 24261

Modified:
   trunk/gsa/ChangeLog
   trunk/gsa/src/gsad.c
Log:
	* src/gsad.c (request_handler): Check that params has been setup before
	accessing param "cmd", because in some cases params is still NULL.
	Prevents a Glib critical error due to accessing NULL as a hashtable.

Modified: trunk/gsa/ChangeLog
===================================================================
--- trunk/gsa/ChangeLog	2016-01-29 16:40:18 UTC (rev 24260)
+++ trunk/gsa/ChangeLog	2016-01-31 12:21:22 UTC (rev 24261)
@@ -1,3 +1,9 @@
+2016-01-31  Matthew Mundell <matthew.mundell@greenbone.net>
+
+	* src/gsad.c (request_handler): Check that params has been setup before
+	accessing param "cmd", because in some cases params is still NULL.
+	Prevents a Glib critical error due to accessing NULL as a hashtable.
+
 2016-01-29  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>
 
 	* src/html/classic/omp.xsl (name="include-message-default")

Modified: trunk/gsa/src/gsad.c
===================================================================
--- trunk/gsa/src/gsad.c	2016-01-29 16:40:18 UTC (rev 24260)
+++ trunk/gsa/src/gsad.c	2016-01-31 12:21:22 UTC (rev 24261)
@@ -4532,7 +4532,12 @@
       if (response)
         {
           const char* cmd;
-          cmd = params_value (credentials->params, "cmd");
+
+          if (credentials->params)
+            cmd = params_value (credentials->params, "cmd");
+          else
+            cmd = NULL;
+
           if (attach_sid (response, sid) == MHD_NO)
             {
               g_free (sid);

_______________________________________________
Openvas-commits mailing list
Openvas-commits@wald.intevation.org
https://lists.wald.intevation.org/cgi-bin/mailman/listinfo/openvas-commits
[prev in list] [next in list] [prev in thread] [next in thread]