[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openvas-cvs
Subject:    [Openvas-commits] r16519 - in trunk/openvas-scanner: . src
From:       scm-commit () wald ! intevation ! org
Date:       2013-05-31 9:57:34
Message-ID: 20130531095734.415B99A1907E () wald ! intevation ! org
[Download RAW message or body]

Author: mwiegand
Date: 2013-05-31 11:57:34 +0200 (Fri, 31 May 2013)
New Revision: 16519

Modified:
   trunk/openvas-scanner/ChangeLog
   trunk/openvas-scanner/src/pluginlaunch.c
   trunk/openvas-scanner/src/pluginscheduler.c
Log:
Mark results of code analysis based on a number of valgrind runs.

  * src/pluginlaunch.c (process_internal_msg): Add TODO regarding
  possible memleak.

  * src/pluginscheduler.c (plugins_scheduler_init): Add TODO regarding
  possible memleak.


Modified: trunk/openvas-scanner/ChangeLog
===================================================================
--- trunk/openvas-scanner/ChangeLog	2013-05-31 09:27:49 UTC (rev 16518)
+++ trunk/openvas-scanner/ChangeLog	2013-05-31 09:57:34 UTC (rev 16519)
@@ -1,3 +1,13 @@
+2013-05-31  Michael Wiegand <michael.wiegand@greenbone.net>
+
+	Mark results of code analysis based on a number of valgrind runs.
+
+	* src/pluginlaunch.c (process_internal_msg): Add TODO regarding
+	possible memleak.
+
+	* src/pluginscheduler.c (plugins_scheduler_init): Add TODO regarding
+	possible memleak.
+
 2013-05-30  Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net>
 
 	* src/users.c (check_user): Remove any handling of the user name,

Modified: trunk/openvas-scanner/src/pluginlaunch.c
===================================================================
--- trunk/openvas-scanner/src/pluginlaunch.c	2013-05-31 09:27:49 UTC (rev 16518)
+++ trunk/openvas-scanner/src/pluginlaunch.c	2013-05-31 09:57:34 UTC (rev 16519)
@@ -130,6 +130,10 @@
   else
     log_write ("Received unknown message type %d\n", type);
 
+  /**
+   * @TODO: Valgrind reports this as a possible memleak. Why is only freed under
+   * certain conditions? Shouldn't it always or never be freed?
+   */
   if (bufsz > 65535)
     efree (&buffer);
 

Modified: trunk/openvas-scanner/src/pluginscheduler.c
===================================================================
--- trunk/openvas-scanner/src/pluginscheduler.c	2013-05-31 09:27:49 UTC (rev 16518)
+++ trunk/openvas-scanner/src/pluginscheduler.c	2013-05-31 09:57:34 UTC (rev 16519)
@@ -530,6 +530,9 @@
       scheduler_plugin->category = category;
       scheduler_plugin->timeout = nvti_timeout (nvti);
 
+      /**
+       * @TODO: Valgrind reports a possible memleak in the str2arglist usage.
+       */
       scheduler_plugin->required_ports = str2arglist (nvti_required_ports (nvti));
       scheduler_plugin->required_udp_ports = str2arglist (nvti_required_udp_ports (nvti));
       scheduler_plugin->required_keys = str2arglist (nvti_required_keys (nvti));

_______________________________________________
Openvas-commits mailing list
Openvas-commits@wald.intevation.org
https://lists.wald.intevation.org/cgi-bin/mailman/listinfo/openvas-commits
[prev in list] [next in list] [prev in thread] [next in thread]