[prev in list] [next in list] [prev in thread] [next in thread] 

List:       opensuse-packaging
Subject:    Re: [opensuse-packaging] Re: rpmlint, or whatever checks
From:       Cristian Rodríguez <crrodriguez () opensuse ! org>
Date:       2014-02-28 2:52:42
Message-ID: 530FF9FA.4040107 () opensuse ! org
[Download RAW message or body]

El 27/02/14 13:33, Bernhard Voelker escribió:
> On 02/27/2014 04:52 PM, Ruediger Meier wrote:
>>    v->rvsn = hextou(++bp, &bp);
>
> At least it's pretty ugly.
> And even if it works today - it most probably won't
> anymore if someone changes hextou into a macro (or if
> it is one today: if someone changes it into a function).
> Therefore it is at least bad to maintain.
> I'd split off the ++bp into a separate statement.
>

Also, ++bp may be evaluated more than once in the case of a macro.. and 
that's extremely difficult to debug.

-- 
To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org
To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org

[prev in list] [next in list] [prev in thread] [next in thread]