[prev in list] [next in list] [prev in thread] [next in thread] 

List:       opensuse-packaging
Subject:    Re: [opensuse-packaging] glibc 2.7 in Beta testing
From:       Marcus Meissner <meissner () suse ! de>
Date:       2007-11-26 9:03:34
Message-ID: 20071126090333.GA27216 () suse ! de
[Download RAW message or body]

On Mon, Nov 26, 2007 at 09:55:12AM +0100, Stephan Kulow wrote:
> Hi!
> 
> Petr checked in glibc 2.7 into autobuild and we see build failures in quite 
> some packages that look like this one:
> 
> In function 'int open(const char*, int, ...)',
>     inlined from 'void NCurses::RedirectToLog()' at NCurses.cc:587:
> /usr/include/bits/fcntl2.h:51: error: call to '__open_missing_mode' declared 
> with attribute error: open with O_CREAT in second argument needs 3 arguments
> 
> I think the error is speaking for itself, in case it does not: this is about 
> 
>        int open(const char *pathname, int flags);
>        int open(const char *pathname, int flags, mode_t mode);
> 
> So please fix the code, for most cases 0666 or 0600 should be the right 
> choice.
> 
> BTW: as far as I can tell, glibc 2.6 did not have a default value, so the code
> in question should be buggy and can't have worked before.

It just took what was on the stack / the 3rd register argument register ... 
aka "randomness" ;)

Ciao, Marcus
---------------------------------------------------------------------
To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org
For additional commands, e-mail: opensuse-packaging+help@opensuse.org

[prev in list] [next in list] [prev in thread] [next in thread]