[prev in list] [next in list] [prev in thread] [next in thread] 

List:       opensuse-buildservice
Subject:    [opensuse-buildservice] [PATCH 1/4] Revert "don't display 'keeping ..' messages. That's rather unint
From:       Jan Engelhardt <jengelh () inai ! de>
Date:       2015-06-02 10:59:40
Message-ID: 1433242783-3506-2-git-send-email-jengelh () inai ! de
[Download RAW message or body]

This reverts commit e2a3a2681057293a452938cb523783f8d88809e6.

That commit crippled progress reporting. Issue 1: It made the
"keeping" messages go away, but the progress indicator would still be
printed, so the commit only did half of the intent.

Issue 2: Since no newline was emitted (this was part of the "keeping"
message) and because stdout is line-buffered, the progress report
would only be sporadically emitted.

Furthermore, initializating a Debian root is slow compared to RPM, and
so there is a long time before any output is shown.

Show me my progress as it happens. Reinstate messages about kept
packages.
---
 init_buildsystem | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/init_buildsystem b/init_buildsystem
index 1d3587e..d63f3c2 100755
--- a/init_buildsystem
+++ b/init_buildsystem
@@ -883,7 +883,7 @@ for PKG in $MAIN_LIST ; do
 	read PKGID < $BUILD_ROOT/.init_b_cache/rpms/$PKG.id
 	read OLDPKGID < $BUILD_ROOT/.init_b_cache/alreadyinstalled/$PKG
 	if test "$PKGID" = "$OLDPKGID" ; then
-	    #echo "keeping ${PKGID%% *}"
+	    echo "keeping ${PKGID%% *}"
 	    rm -f $BUILD_ROOT/.init_b_cache/$PKG.$PSUF
 	    echo "$PKGID" > $BUILD_ROOT/installed-pkg/$PKG
 	    test -n "$PKG_HDRMD5" && echo "$PKG_HDRMD5 $PKGID" > $BUILD_ROOT/.preinstall_image/$PKG
@@ -900,7 +900,7 @@ for PKG in $MAIN_LIST ; do
 	    pkg_erase
 	else
 	    if test "$VERIFY_BUILD_SYSTEM" != true || pkg_verify_installed ; then
-		#echo "keeping ${PKGID%% *}"
+		echo "keeping ${PKGID%% *}"
 		echo "$PKGID" > $BUILD_ROOT/installed-pkg/$PKG
 		test -n "$PKG_HDRMD5" && echo "$PKG_HDRMD5 $PKGID" > $BUILD_ROOT/.preinstall_image/$PKG
 		continue
-- 
2.4.0

-- 
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org
To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org

[prev in list] [next in list] [prev in thread] [next in thread]