[prev in list] [next in list] [prev in thread] [next in thread] 

List:       opensuse-buildservice
Subject:    Re: [opensuse-buildservice] Re: [PATCH] - do_update: rewrote code path for expanding/unexpanding a w
From:       Marcus =?iso-8859-1?Q?H=FCwe?= <suse-tux () gmx ! de>
Date:       2012-03-29 13:33:37
Message-ID: 20120329133337.GB2335 () linux ! uni-paderborn ! de
[Download RAW message or body]

On 2012-03-29 14:22:24 +0200, Michael Schroeder wrote:
> On Thu, Mar 29, 2012 at 01:22:27PM +0200, Marcus Hüwe wrote:
> > IMHO it's a semantic question: what is "osc up -e" and "osc up -u"
> > supposed to do? The old behaviour was:
> > "osc up -e": update to the latest rev and expand it
> > "osc up -u": update to the current rev and don't expand it
> 
Hrm I just realized that this is wrong. Even the old code (before commit
081037e9137a74fd36f18b15bf9e0f18203d49fd) checked out the latest
rev (in both cases) and expands it (if -e was specified).

> Dunno, I always thought it was:
> 
>     "osc up -e": keep the current rev, but expand
>     "osc up -u": keep the current rev, but unexpand
> 
> I that's no longer true, we need to provide the functionality
> in some way.
> 
This was changed in commit beae2c0cdd7da60e595ff43d66f484f94dded6c0 (in
2010).

What do you think, should we keep the current behaviour or restore the
"original" one?


Marcus
-- 
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org
To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org

[prev in list] [next in list] [prev in thread] [next in thread]