[prev in list] [next in list] [prev in thread] [next in thread] 

List:       opensuse-buildservice
Subject:    Re: [opensuse-buildservice] [PATCH] Notifications do not support multiple action requests
From:       Klaas Freitag <freitag () suse ! de>
Date:       2010-10-07 8:45:35
Message-ID: 201010071045.35946.freitag () suse ! de
[Download RAW message or body]

On Wednesday 06 October 2010 10:08:29 Islam Amer wrote:
> Hello,
> 
> Great then! I have already applied the patch to our OBS, and it is 
> working fine.
> 
> The AMQP and BOSS notification plugins didn't need to be modified 
> because they just dump the data structure as is.
> 
> Should I try to fix the hermes notification plugin as well ? I don't 
> exactly know what hermes expects though :)
That would be great, because nowadays the Hermes plugin only works
with one notification per request, because Hermes can not yet handle 
multiple notifications in one HTTP request. But that can and should
be changed. If you change the plugin on backend side, I will fix 
Hermes for that.

Thanks,

Klaas

> On 10/05/2010 05:19 PM, ext Klaas Freitag wrote:
> > On Tuesday 05 October 2010 15:56:35 Islam Amer wrote:
> > Hi,
> >>
> >> Welcome back :)
> > Thanks :)
> >>
> >> We are using a different notification plugin (AMQP, BOSS). I can fix the
> >> hermes notification plugin, but I don't know where to start with hermes
> >> itself.
> >>
> >> But at least is the basic idea of the patch acceptable ?
> > Yes, absolutely. If that works with your notification plugin, we can
> > agree on that change and I change Hermes accordingly.
> >
> > regards,
> >
> > Klaas
> >
> >>
> >> On 10/05/2010 03:56 PM, ext Klaas Freitag wrote:
> >>> On Thursday 30 September 2010 10:01:28 Adrian Schröter wrote:
> >>>>
> >>> Hi Islam,
> >>>
> >>> thanks for working on that. That is a long outstanding feature request.
> >>>
> >>>>> I was trying out multiple actions in one request and noticed that the
> >>>>> notifications contain only the last action.
> >>>>>
> >>>>> I looked at the code and found this in /usr/lib/obs/server/BSNotify.pm
> >>>>> line 82 :
> >>>>>
> >>>>>        # FIXME: how to handle multiple actions in one request here ?
> >>>>>        # right now the last one just wins ....
> >>>>>
> >>>>> So here's a proposed fix : add an actions key in the reqinfo hash, that
> >>>>> contains an ordered list of hashes that contain the details of the actions.
> >>> That is, in our case, only half the way. We're using Hermes as notification
> >>> system. As your patch changes the format of what is sent to Hermes via http
> >>> we have to make Hermes understanding that as well.
> >>>
> >>> I think your proposal is great, but please remember that we need to change
> >>> the notification systems before we can deploy it.
> >>>
> >>> Are you also using Hermes or another system?
> >>>
> >>> Thanks for your help,
> >>>
> >>> Klaas
> >>
> 
-- 
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org
For additional commands, e-mail: opensuse-buildservice+help@opensuse.org


[prev in list] [next in list] [prev in thread] [next in thread]