[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openssl-dev
Subject:    [PATCH] building on Windows: support MINFO with CRs
From:       Oren Held <oren () held ! org ! il>
Date:       2011-01-14 10:39:38
Message-ID: 4D3027EA.4080700 () held ! org ! il
[Download RAW message or body]

Hello,

In OpenSSL's windows build system, when MINFO file has carriage-returns
- it breaks the whole Makefile creation (mk1mf.pl).

Similar reports could be seen here:
http://www.mail-archive.com/openssl-users@openssl.org/msg27400.html,
http://www.mail-archive.com/openssl-users@openssl.org/msg17449.html

It's not directly OpenSSL's fault, but I still believe that its build
scripts should support dos-formatted files as input, especially when the
patch is simple enough.

Cheers

Oren

["openssl-support-MINFO-with-carriage-return.patch" (text/x-patch)]

--- openssl-1.0.0c/util/mk1mf.pl	2010-09-02 20:23:36.000000000 +0300
+++ openssl-1.0.0c/util/mk1mf.pl.new	2011-01-14 12:24:55.897916845 +0200
@@ -317,6 +317,7 @@
 for (;;)
 	{
 	chop;
+	s/\r//;
 
 	($key,$val)=/^([^=]+)=(.*)/;
 	if ($key eq "RELATIVE_DIRECTORY")

______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       openssl-dev@openssl.org
Automated List Manager                           majordomo@openssl.org

[prev in list] [next in list] [prev in thread] [next in thread]