[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openssl-dev
Subject:    Re: PATCH: mutex lock around lazy eval of method_mont_p in dsa_ossl.c
From:       Marius Schilder <marius_schilder () yahoo ! com>
Date:       2005-02-03 5:55:35
Message-ID: 20050203055536.54350.qmail () web30804 ! mail ! mud ! yahoo ! com
[Download RAW message or body]

why do i keep submitting flawed patches? surely i'm in
killfiles by now ;-) the alloc should go to a tmp, and
after the computation assign the tmp to the struct
member so it's ready for use.. anyone care for a
correct patch?

--- Marius Schilder <marius_schilder@yahoo.com> wrote:

> Hi,
> this patch fixes a race condition (memory leak if
> not
> worse) when multi-threading on a DSA* instance.
> DSA_sign_setup() and DSA_do_verify() both have this
> lazy eval code for the method_mont_p member. I added
> a
> CRYPTO_w_lock(CRYPTO_LOCK_DSA) around it.
> 
> marius

> ATTACHMENT part 2 application/octet-stream
name=PATCH-LOCK_DSA-openssl-0.9.7e.patch


______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       openssl-dev@openssl.org
Automated List Manager                           majordomo@openssl.org
[prev in list] [next in list] [prev in thread] [next in thread]