[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openssl-cvs
Subject:    [CVS] OpenSSL: OpenSSL_0_9_7-stable: openssl/crypto/dh/ dh_key.c opens...
From:       "Andy Polyakov" <appro () openssl ! org>
Date:       2005-04-28 8:52:29
Message-ID: 20050428085229.88206203642 () master ! openssl ! org
[Download RAW message or body]

  OpenSSL CVS Repository
  http://cvs.openssl.org/
  ____________________________________________________________________________

  Server: cvs.openssl.org                  Name:   Andy Polyakov
  Root:   /e/openssl/cvs                   Email:  appro@openssl.org
  Module: openssl                          Date:   28-Apr-2005 10:52:29
  Branch: OpenSSL_0_9_7-stable             Handle: 2005042809522801

  Modified files:           (Branch: OpenSSL_0_9_7-stable)
    openssl/crypto/dh       dh_key.c
    openssl/fips            fipshashes.c
    openssl/fips/dh         fips_dh_key.c

  Log:
    Pointer to BN_MONT_CTX could be used uninitialized.

  Summary:
    Revision    Changes     Path
    1.16.2.5    +2  -2      openssl/crypto/dh/dh_key.c
    1.1.2.5     +2  -2      openssl/fips/dh/fips_dh_key.c
    1.1.2.7     +1  -1      openssl/fips/fipshashes.c
  ____________________________________________________________________________

  patch -p0 <<'@@ .'
  Index: openssl/crypto/dh/dh_key.c
  ============================================================================
  $ cvs diff -u -r1.16.2.4 -r1.16.2.5 dh_key.c
  --- openssl/crypto/dh/dh_key.c	22 Apr 2005 13:17:45 -0000	1.16.2.4
  +++ openssl/crypto/dh/dh_key.c	28 Apr 2005 08:52:28 -0000	1.16.2.5
  @@ -105,7 +105,7 @@
   	int generate_new_key=0;
   	unsigned l;
   	BN_CTX *ctx;
  -	BN_MONT_CTX *mont;
  +	BN_MONT_CTX *mont=NULL;
   	BIGNUM *pub_key=NULL,*priv_key=NULL;
   
   	ctx = BN_CTX_new();
  @@ -162,7 +162,7 @@
   static int compute_key(unsigned char *key, const BIGNUM *pub_key, DH *dh)
   	{
   	BN_CTX *ctx;
  -	BN_MONT_CTX *mont;
  +	BN_MONT_CTX *mont=NULL;
   	BIGNUM *tmp;
   	int ret= -1;
   
  @@ .
  patch -p0 <<'@@ .'
  Index: openssl/fips/dh/fips_dh_key.c
  ============================================================================
  $ cvs diff -u -r1.1.2.4 -r1.1.2.5 fips_dh_key.c
  --- openssl/fips/dh/fips_dh_key.c	22 Apr 2005 13:17:48 -0000	1.1.2.4
  +++ openssl/fips/dh/fips_dh_key.c	28 Apr 2005 08:52:29 -0000	1.1.2.5
  @@ -108,7 +108,7 @@
   	int generate_new_key=0;
   	unsigned l;
   	BN_CTX *ctx;
  -	BN_MONT_CTX *mont;
  +	BN_MONT_CTX *mont=NULL;
   	BIGNUM *pub_key=NULL,*priv_key=NULL;
   
   	ctx = BN_CTX_new();
  @@ -164,7 +164,7 @@
   static int compute_key(unsigned char *key, const BIGNUM *pub_key, DH *dh)
   	{
   	BN_CTX *ctx;
  -	BN_MONT_CTX *mont;
  +	BN_MONT_CTX *mont=NULL;
   	BIGNUM *tmp;
   	int ret= -1;
   
  @@ .
  patch -p0 <<'@@ .'
  Index: openssl/fips/fipshashes.c
  ============================================================================
  $ cvs diff -u -r1.1.2.6 -r1.1.2.7 fipshashes.c
  --- openssl/fips/fipshashes.c	24 Apr 2005 21:17:53 -0000	1.1.2.6
  +++ openssl/fips/fipshashes.c	28 Apr 2005 08:52:28 -0000	1.1.2.7
  @@ -14,7 +14,7 @@
   "HMAC-SHA1(des/fips_des_locl.h)= e008da40dc6913e374edd66a20d44e1752f00583",
   "HMAC-SHA1(dh/fips_dh_check.c)= 63347e2007e224381d4a7b6d871633889de72cf3",
   "HMAC-SHA1(dh/fips_dh_gen.c)= 93fe69b758ca9d70d70cda1c57fff4eb5c668e85",
  -"HMAC-SHA1(dh/fips_dh_key.c)= 90bdc0c2c55aea2feecd16bf9b4bc3717d4c32f4",
  +"HMAC-SHA1(dh/fips_dh_key.c)= 0b810d411090abd6b676a7ca730c35362fbd04a4",
   "HMAC-SHA1(dsa/fips_dsa_ossl.c)= 0ff7c3aa1cb111f14ff253870fc2eddfd2224d06",
   "HMAC-SHA1(dsa/fips_dsa_gen.c)= c252db14699f3ff641db052311da7d7521569c53",
   "HMAC-SHA1(dsa/fips_dsa_selftest.c)= 7c2ba8d82feda2aadc8b769a3b6c4c25a6356e01",
  @@ .
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
CVS Repository Commit List                     openssl-cvs@openssl.org
Automated List Manager                           majordomo@openssl.org
[prev in list] [next in list] [prev in thread] [next in thread]