[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openssh-unix-dev
Subject:    Re: FreeBSD change for openssh
From:       Ed Maste <emaste () freebsd ! org>
Date:       2021-11-17 15:10:55
Message-ID: CAPyFy2Dmb6XxqWKx+OwsDnh89SW0SrFCdA17rFV_qKj4CXxiJw () mail ! gmail ! com
[Download RAW message or body]

On Mon, 15 Nov 2021 at 11:51, Mike Karels <karels@freebsd.org> wrote:
>
> +#ifndef IN_LOOPBACK
> +#define IN_LOOPBACK(i)         (((i) & 0xff000000) == 0x7f000000)
> +#endif
...
>  static int
>  sockaddr_is_local(struct sockaddr *hostaddr)
>  {
>         switch (hostaddr->sa_family) {
>         case AF_INET:
> -               return (ntohl(((struct sockaddr_in *)hostaddr)->
> -                   sin_addr.s_addr) >> 24) == IN_LOOPBACKNET;
> +               return (IN_LOOPBACK(ntohl(((struct sockaddr_in *)hostaddr)->
> +                   sin_addr.s_addr)));

Looks fine to me.

IMO #ifndef is reasonable as it's unlikely that IN_LOOPBACK() would be
implemented as other than a macro anywhere, but could be a full
autoconf check if that's what OpenSSH folks want.
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
[prev in list] [next in list] [prev in thread] [next in thread]