[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openssh-unix-dev
Subject:    Re: New dynamic window patch (with limits)
From:       Michael Stevens <stevensm () gmail ! com>
Date:       2004-07-15 14:00:19
Message-ID: 70621a4604071507003097c42b () mail ! gmail ! com
[Download RAW message or body]

It would be nice, but I'm not sure that this won't let someone
remotely consume large amounts of memory in some other part of the
code. I don't know the code well enough to say that would be fine. If
there would be no problems with that, I wouldn't have a problem
changing the patch.

Mike

On Thu, 15 Jul 2004 12:39:25 +1000, Damien Miller <djm@mindrot.org> wrote:
> Michael Stevens wrote:
> 
> > Only in openssh-3.8.1p1-dynwindow: Makefile
> > diff -u openssh-3.8.1p1/buffer.c openssh-3.8.1p1-dynwindow/buffer.c
> > --- openssh-3.8.1p1/buffer.c  2003-11-21 07:56:47.000000000 -0500
> > +++ openssh-3.8.1p1-dynwindow/buffer.c        2004-07-12 07:49:29.000000000 -0400
> > @@ -18,6 +18,12 @@
> >  #include "buffer.h"
> >  #include "log.h"
> >
> > +void
> > +set_unlimited(Buffer *buffer, int new_value)
> > +{
> > +     buffer->unlimited = new_value;
> > +}
> > +
> 
> I really don't think we should add options to the buffer code. If we
> need to increase the buffer size limits, then we should just choose a
> safe maximum and crank them for all users.
> 
> -d
> 
>

_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
http://www.mindrot.org/mailman/listinfo/openssh-unix-dev
[prev in list] [next in list] [prev in thread] [next in thread]