[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openssh-bugs
Subject:    [Bug 2625] Support Capabilities for ssh client port forwarding
From:       bugzilla-daemon () bugzilla ! mindrot ! org
Date:       2016-10-24 6:10:15
Message-ID: bug-2625-705-WIgG8t5Pvm () https ! bugzilla ! mindrot ! org/
[Download RAW message or body]

https://bugzilla.mindrot.org/show_bug.cgi?id=2625

--- Comment #5 from Darren Tucker <dtucker@zip.com.au> ---
(In reply to Alexey Mochkin from comment #4)
> Your bind_permitted() function should have fallback to check for uid
> == 0 if no capabilities were presented.

fair enough, but it'd be cleaner if it just fell through, eg:

int
bind_permitted(int port, uid_t uid)
{
#ifdef LINUX_CAPABILITIES
        if (linux_capability_bind_permitted())
                return 1;
#endif
        if (port < IPPORT_RESERVED && uid != 0)
                return 0;
        return 1;

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[prev in list] [next in list] [prev in thread] [next in thread]