[prev in list] [next in list] [prev in thread] [next in thread] 

List:       opensolaris-tools-discuss
Subject:    Re: [tools-discuss] [scm-migration-dev] code review request for
From:       "Mark J. Nelson" <Mark.J.Nelson () Sun ! COM>
Date:       2008-06-20 14:31:07
Message-ID: alpine.SOC.1.00.0806200827560.8883 () mrliberal
[Download RAW message or body]


Sorry, the bug reference was to bugs.grommit.com:

 	http://bugs.grommit.com/show_bug.cgi?id=481

...and the actually useful webrev is

 	http://cr.opensolaris.org/~mjnelson/webrev.481.2/

...and to answer your question, "no."  Because usr/closed is actually a 
separate Mercurial repository, nested inside the open-only repository. 
Some folks inside of Sun will populate it, some won't, and it won't appear 
outside of Sun (for obvious reasons).  So the hg locate default operation 
(whole repository) is the same as what you describe.

--Mark


On Fri, 20 Jun 2008, Stacey Marshall wrote:

> Date: Fri, 20 Jun 2008 06:38:33 -0700 (PDT)
> From: Stacey Marshall <Stacey.Marshall@Sun.COM>
> To: tools-discuss@opensolaris.org
> Subject: Re: [tools-discuss] [scm-migration-dev] code review request for
> nightly.sh and webrev.sh
> 
> Bug 481, really?
> 
> So, this may also be out-of-scope, but looking at this section of \
> usr/src/tools/scripts/nightly.sh: 
> 375         if [[ -n "$closed_top" ]]; then
> 376                 mkdir -p "$dest/usr/closed" || return 1
> 377                 if [[ "$closed_top" = usr/closed ]]; then
> 378                         (cd usr/closed; hg locate |
> 379                             cpio -pd "$dest/usr/closed") >>$LOGFILE 2>&1
> 380                         if [ $? -ne 0 ]; then
> 381                             echo "cpio failed for $dest/usr/closed" |
> 382                                 tee -a $mail_msg_file >> $LOGFILE
> 383                             return 1
> 384                         fi
> 385                 else
> 386                         # copy subtree of usr/closed
> 387                         closed_top=${closed_top#usr/closed/}
> 388                         (cd usr/closed; hg locate "$closed_top" |
> 389                             cpio -pd "$dest/usr/closed") >>$LOGFILE 2>&1
> 390                         if [ $? -ne 0 ]; then
> 391                             echo "cpio failed for " \
> 392                                 "$dest/usr/closed/$closed_top" |
> 393                                 tee -a $mail_msg_file >> $LOGFILE
> 394                             return 1
> 395                         fi
> 
> The 'hg locate' commands on line 378 and 388 follow a 'cd usr/closed', should the \
> hg locate commands append '--include .' to limit the list of located files to \
> 'usr/closed'? 
> Regards,  Stace
> 
> 
> This message posted from opensolaris.org
> _______________________________________________
> tools-discuss mailing list
> tools-discuss@opensolaris.org
> 
_______________________________________________
tools-discuss mailing list
tools-discuss@opensolaris.org


[prev in list] [next in list] [prev in thread] [next in thread]