[prev in list] [next in list] [prev in thread] [next in thread] 

List:       opensolaris-networking-discuss
Subject:    [networking-discuss] Clearview: Nemo MAC-Type Plugin	Architecture
From:       Sebastien.Roy () Sun ! COM (Sebastien Roy)
Date:       2006-04-12 20:15:09
Message-ID: 1144898103.1764.3.camel () localhost
[Download RAW message or body]

On Wed, 2006-04-12 at 20:41 -0400, Peter Memishian wrote:
>  > Sebastien Roy wrote:
>  > > http://www.opensolaris.org/os/project/clearview/nemo-mactype-plugins.txt
> 
> Nice job.
> 
> I think there are too many names and abbreviations for plugin data now:
> "MAC state data", "state data", "plugin data", "plugin_data",
> "MTOPS_PDATA_VERIFY", mac_plugindata_update().  I suggest we always call
> it "MAC plugin data", and use the "pdata" abbreviation consistently for
> code -- e.g., mac_pdata_update(); `void *pdata'; MTOPS_PDATA_VERIFY.

Agreed.

> 
> A few other nits:
> 
>   This allows mactype_alloc() to verify if the plugin was compiled against
>   an incompatible version of the MAC-Type framework.  A version mismatch
>      ^^^^^^^^^^^^
>   will result in mactype_alloc()
> 
> "Compatible" seems more appropriate here.

Uh, yes.  Brain cramp.

> 
>   Immediately after having registered using mactype_register(), the
>   mactype_register_t used to register must be freed using mactype_free().
> 
> The word "Immediately" seems odd here; suggest removing.

Sure.

> 
>     There is one strict requirement that the GLDv3 framework poses on MAC
>     type plugins regarding statistics.  All statistics defined by plugins
>                                      ^^^^
>     must have a minimum value of MACTYPE_STAT_MIN.  
> 
> Suggest a `:' here instead.

Ok.

Thanks,
-Seb


[prev in list] [next in list] [prev in thread] [next in thread]