[prev in list] [next in list] [prev in thread] [next in thread] 

List:       opensolaris-install-discuss
Subject:    [install-discuss] Re: [request-sponsor] Sponsor request for 6443055
From:       Peter Tribble <P.Tribble () herts ! ac ! uk>
Date:       2006-06-28 9:12:47
Message-ID: 1151485967.14629.19.camel () platinum
[Download RAW message or body]

On Wed, 2006-06-28 at 08:34, Willi Burmeister wrote:

[to request-sponsor, but I've redirected to install-discuss]

> I'd like to find a sponsor for the small fix for
>   
>   6443055 pkgchk und pkgtrans are not able to deal with 32 char package names
>   
> The patch is included in the bug report
> 
>    http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6443055

I don't think that's complete. Looks to me like the
problem really is the use of NON_ABI_NAMELNGTH in the
struct dstoc definition. Not that I'm saying your fix
is wrong, but I think that there are other problems
in this area.

Looking at this (and another similar bug that I have
ongoing - 6424003), the definition of the maximum length
of a package name does seem a little inconsistent in the
code. We have NON_ABI_NAMELNGTH (which is 32) in some
places (not many). More common is PKGSIZ (which is 64)
although even there sometimes it's PKGSIZ, and in other
places PKGSIZ+1.

I've logged a bug for this (no bugid yet), but that bug
merely requests consistency.

Which leaves open the question: what is the maximum length
of a package name? And does that include the terminating null?

-- 
-Peter Tribble
L.I.S., University of Hertfordshire - http://www.herts.ac.uk/
http://www.petertribble.co.uk/ - http://ptribble.blogspot.com/


_______________________________________________
install-discuss mailing list
install-discuss@opensolaris.org
http://opensolaris.org/mailman/listinfo/install-discuss
[prev in list] [next in list] [prev in thread] [next in thread]