[prev in list] [next in list] [prev in thread] [next in thread] 

List:       opensolaris-companion-discuss
Subject:    Re: [companion-discuss] Code Review Request: Update of SFWenscr
From:       Paul Cunningham <paul.cunningham () tadpole ! com>
Date:       2009-01-06 11:09:47
Message-ID: 49633BFB.1080909 () tadpole ! com
[Download RAW message or body]

Steve,

Also looks good to me, just a very minor comments ..

Paul

Steve Christensen wrote:
> This is a code review request for the update of the SFWenscr package to version \
> 1.6.4.  The webrev is at 
> http://companion.sunfreeware.com/downloads/enscriptwebrev/
> 
> Details:
> 
> 1. METADATA file added.
> 2. Copyright dates and version numbers updated where needed.
> 3. Source file updated.
> 4. One CC line in Makefile.sfw removed as this causes a failed build due to a
> known bug in the configure file for 1.6.4.
> 5. fi language files removed in prototype_com since these do not exist in 1.6.4.
> 6. Various file locations fixed in install-sfw.
> 
> The package builds cleanly and produces a working SFWenscr package.


1. src/cmd/enscript/METADATA
    Change lower case characters ...
      bugtRAQ:  --->  BUGTRAQ:

-- 
----------------------------------------------------------------------
Paul Cunningham
Software Engineer
Tadpole Business Unit
_______________________________________________
companion-discuss mailing list
companion-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/companion-discuss


[prev in list] [next in list] [prev in thread] [next in thread]