[prev in list] [next in list] [prev in thread] [next in thread]
List: opensolaris-code
Subject: Re: [osol-code] read-only filesystems...
From: Frank.Hofmann () Sun ! COM
Date: 2008-02-04 16:45:39
Message-ID: Pine.GSO.4.64.0802041644430.28758 () armageddon
[Download RAW message or body]
On Mon, 4 Feb 2008, Garrett D'Amore wrote:
> Frank.Hofmann@Sun.COM wrote:
>> On Fri, 1 Feb 2008, Garrett D'Amore wrote:
>>
>> >
>> > Okay, thanks. If you send diffs, I can act as code reviewer, and I can
>> > also validate them, and if necessary, integrate them. (Although we may
>> > need to reverse reviewer and integrator roles in that case.) I was
>> > actually planning on taking a close look at maybe working on this bug
>> > myself anyway.
>> >
>> > Anyway, just let me know what help, if any, you would like from me.
>> >
>> > -- Garrett
>>
>> Hi Garrett,
>>
>> have attached a diff for the following ones:
>>
>> 6587983 PCFS pc_validcl() check is incorrect / too restrictive after fix
>> for 5047630
>> 6613462 Write protected zip drive does not get mounted in public zone in
>> TX10x86
>> 6620847 pcfs mount fails on SNV_b75
>>
>> The first one is likely not 100% complete (adjustments to pc_alloc.c are
>> advisable there as well, but need to look at the details again - this is
>> prone to have one-off errors ...) and would need cornercase testing, but
>> then it's pretty easy to separate that one out if you like.
>>
>> I don't have a cr.opensolaris.org account yet (had cr.grommit.com but
>> missed the switchover), so I can't put the webrev in public right now;
>> Sun-internal, it's at /net/tb3.uk/tank/u/frankho/pcfs-misc/ see there.
>
> Cool. I'll take a look, and post it up at my account. Any objections if I
> just push these fixes through?
I'd leave 6587983 out unless you're sure it's not (re)creating one-off
errors (like 5047630 ...). As said I had wanted to test that one a bit
more.
All else, fine with me.
Thanks for helping with this one !
FrankH.
>
> -- Garrett
>>
>> I'll be back in April,
>>
>> Best regards,
>> FrankH.
>>
>>
>> >
>> > Frank Hofmann wrote:
>> > >
>> > > Ok, see this thing now.
>> > >
>> > > Disks can be opened as read/write even if you're requesting a
>> > > readonly
>> > > mount. It seems the flash-based media that are lockable actually
>> > > refuse
>> > > the writeable open hence it fails.
>> > >
>> > > Also, the order of things in pcfs_mount is wrong. It's not so much
>> > > that
>> > > device_identify() is done before parse_mntopts() but rather that the
>> > > VOP_OPEN() call is done before then. Quite a few things need to be
>> > > moved
>> > > around:
>> > >
>> > > - the instance structure is needed far earlier - before
>> > > device_identify
>> > > to get everything correct.
>> > > - the mount option parsing needs to be done first
>> > > - have device_identify (which checks for VFS_RDONLY as well) done
>> > > after
>> > > - have the VOP_OPEN() stuff done after
>> > >
>> > > - make sure that the vfs_bsize assignment is only made after
>> > > pc_getfattype() was called - pcfs_clsize isn't initialized before.
>> > >
>> > > Sometimes, it helps if people actually _look_ at the code - thanks !
>> > >
>> > > I'm on holiday starting mid next week; I should be able to send you
>> > > diffs
>> > > out for that fix, but cannot possibly integrate anything by then.
>> > >
>> > > FrankH.
>> > >
>> > >
>> > > On Fri, 1 Feb 2008, Frank Hofmann wrote:
>> > >
>> > > > > > On Fri, 1 Feb 2008, Artem Kachitchkine wrote:
>> > > > > > > > > gdamore@paprika{123}> pfexec truss -f -t mount mount -F
>> > > pcfs -o ro
>> > > > > > /dev/dsk/c2t0d0p0:1 /mnt
>> > > > > > 3708: mount("/dev/dsk/c2t0d0p0:1", "/mnt", MS_OPTIONSTR,
>> > > "pcfs",
>> > > > > > 0x00000000, 0, 0x08063240, 1024) Err#30 EROFS
>> > > > > > mount: Read-only file system
>> > > > > > > As another data point, submitter of 6642367 reports the
>> > > same issue > > with
>> > > > > USB-connected SD media on snv_79 and claims that it used to
>> > > work on > > snv_64a.
>> > > > > It's a bug. The VOP_OPEN() of the device isn't done with the
>> > > proper > flags.
>> > > > > Can't tell you out of my head why the changes to PCFS done
>> > > inbetween > those
>> > > > two builds caused it. Still, a bug.
>> > > > > Thx,
>> > > > FrankH.
>> > > > > > > > -Artem
>>>>>> _______________________________________________
>> > > > > opensolaris-code mailing list
>> > > > > opensolaris-code@opensolaris.org
>> > > > > http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
>> > > > >
>>>>> _______________________________________________
>> > > > opensolaris-code mailing list
>> > > > opensolaris-code@opensolaris.org
>> > > > http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
>> > > >
>> >
>> >
>>
>> ------------------------------------------------------------------------------
>>
>> No good can come from selling your freedom, not for all the gold in the
>> world,
>> for the value of this heavenly gift far exceeds that of any fortune on
>> earth.
>> ------------------------------------------------------------------------------
>>
>
>
------------------------------------------------------------------------------
No good can come from selling your freedom, not for all the gold in the world,
for the value of this heavenly gift far exceeds that of any fortune on earth.
------------------------------------------------------------------------------
_______________________________________________
opensolaris-code mailing list
opensolaris-code@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic