[prev in list] [next in list] [prev in thread] [next in thread]
List: openser-devel
Subject: [sr-dev] [kamailio/kamailio] ims_charging: Implemented restore of Ro sessions from database (PR #362
From: mtryfoss via sr-dev <sr-dev () lists ! kamailio ! org>
Date: 2023-10-30 12:27:44
Message-ID: kamailio/kamailio/pull/3622 () github ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
- realtime and shutdown mode support
- removed duplicate entry in doc about "ro_auth_expiry"
- RO_TABLE_VERSION constant did not match inserted value in db schema
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes \
that apply --> <!-- All points should be verified, otherwise, read the \
CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of \
these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that \
apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
Fixed the module so it also use information written to database to restore Ro \
sessions on startup/restart.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3622
-- Commit Summary --
* ims_charging: Implemented restore of Ro sessions from database
-- File Changes --
M src/modules/ims_charging/dialog.c (6)
M src/modules/ims_charging/doc/ims_charging_admin.xml (21)
M src/modules/ims_charging/ims_charging_mod.c (15)
M src/modules/ims_charging/ims_ro.c (2)
M src/modules/ims_charging/ro_db_handler.c (444)
M src/modules/ims_charging/ro_db_handler.h (11)
M src/modules/ims_charging/ro_timer.c (2)
M utils/kamctl/mysql/ims_charging-create.sql (8)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3622.patch
https://github.com/kamailio/kamailio/pull/3622.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3622
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3622@github.com>
[Attachment #5 (text/html)]
<ul dir="auto">
<li>realtime and shutdown mode support</li>
<li>removed duplicate entry in doc about "ro_auth_expiry"</li>
<li>RO_TABLE_VERSION constant did not match inserted value in db schema</li>
</ul>
<h4 dir="auto">Pre-Submission Checklist</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" \
class="task-list-item-checkbox" checked=""> Commit message has the format required by \
CONTRIBUTING guide</li> <li class="task-list-item"><input type="checkbox" id="" \
disabled="" class="task-list-item-checkbox" checked=""> Commits are split per \
component (core, individual modules, libs, utils, ...)</li> <li \
class="task-list-item"><input type="checkbox" id="" disabled="" \
class="task-list-item-checkbox" checked=""> Each component has a single commit (if \
not, squash them into one commit)</li> <li class="task-list-item"><input \
type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> No \
commits to README files for modules (changes must be done to docbook files<br> in \
<code class="notranslate">doc/</code> subfolder, the README file is \
autogenerated)</li> </ul>
<h4 dir="auto">Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" \
class="task-list-item-checkbox" checked=""> Small bug fix (non-breaking change which \
fixes an issue)</li> <li class="task-list-item"><input type="checkbox" id="" \
disabled="" class="task-list-item-checkbox"> New feature (non-breaking change which \
adds new functionality)</li> <li class="task-list-item"><input type="checkbox" id="" \
disabled="" class="task-list-item-checkbox"> Breaking change (fix or feature that \
would change existing functionality)</li> </ul>
<h4 dir="auto">Checklist:</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" \
class="task-list-item-checkbox"> PR should be backported to stable branches</li> <li \
class="task-list-item"><input type="checkbox" id="" disabled="" \
class="task-list-item-checkbox" checked=""> Tested changes locally</li> <li \
class="task-list-item"><input type="checkbox" id="" disabled="" \
class="task-list-item-checkbox"> Related to issue #XXXX (replace XXXX with an open \
issue number)</li> </ul>
<h4 dir="auto">Description</h4>
<p dir="auto">Fixed the module so it also use information written to database to \
restore Ro sessions on startup/restart.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/kamailio/kamailio/pull/3622'>https://github.com/kamailio/kamailio/pull/3622</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/kamailio/kamailio/pull/3622/commits/f1e5839a83bea10c89839dd96b56528768ca5be8" \
class="commit-link">f1e5839</a> ims_charging: Implemented restore of Ro sessions \
from database</li> </ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: \
inline-block">(<a href="https://github.com/kamailio/kamailio/pull/3622/files">8 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3622/files#diff-0d7ffc31695ceee \
440f2abbec30271a7feff2032bf26a3e51421dfa41b8d13a6">src/modules/ims_charging/dialog.c</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3622/files#diff-b71a8c2048ee894 \
0cf46d3b7b457c7c01314fca9e23302ccb1e2f1c695b14160">src/modules/ims_charging/doc/ims_charging_admin.xml</a>
(21)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3622/files#diff-3499b9e62542306 \
ee4ccc97d1a1f6fb271f21b7be2c24664a69fd2f604812382">src/modules/ims_charging/ims_charging_mod.c</a>
(15)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3622/files#diff-7cd7b3b53c89f36 \
d9c7fa1172243ffcbe2fb6a3b4165dba1d51bbe9ebe73b546">src/modules/ims_charging/ims_ro.c</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3622/files#diff-dbabab6637549df \
387daee6f8a85d060ea3dd79de1366710a9a4642d4ef42e43">src/modules/ims_charging/ro_db_handler.c</a>
(444)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3622/files#diff-0cc637f6c18793c \
fb0ae4f4f50e5339a584674ba98a75504bcbcb83ee5831e92">src/modules/ims_charging/ro_db_handler.h</a>
(11)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3622/files#diff-3df48dc52b6908c \
c7c0e5fb7b17577fb9c729808ad9b4198d6a0b3476ac367a7">src/modules/ims_charging/ro_timer.c</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3622/files#diff-8af2f642d7eebe3 \
f1b2bef791400bfa5f3140e6396e9c6558e391a9944528e4f">utils/kamctl/mysql/ims_charging-create.sql</a>
(8)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/kamailio/kamailio/pull/3622.patch'>https://github.com/kamailio/kamailio/pull/3622.patch</a></li>
<li><a href='https://github.com/kamailio/kamailio/pull/3622.diff'>https://github.com/kamailio/kamailio/pull/3622.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br \
/>Reply to this email directly, <a \
href="https://github.com/kamailio/kamailio/pull/3622">view it on GitHub</a>, or <a \
href="https://github.com/notifications/unsubscribe-auth/ABO7UZKMCHKGXQQJNMQQLJ3YB6MMBA \
VCNFSM6AAAAAA6V5XS4SVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE3DQMRTG4ZTCMA">unsubscribe</a>.<br \
/>You are receiving this because you are subscribed to this thread.<img \
src="https://github.com/notifications/beacon/ABO7UZN65NX4JOFRFPKXKJDYB6MMBA5CNFSM6AAAAAA6V5XS4SWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHHKUHK7Y.gif" \
height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: \
none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; \
max-width: 0; max-height: 0; mso-hide: all">Message ID: \
<span><kamailio/kamailio/pull/3622</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/3622",
"url": "https://github.com/kamailio/kamailio/pull/3622",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-leave@lists.kamailio.org
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic