[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openser-devel
Subject:    [sr-dev] Re: [kamailio/kamailio] topoh: uses socket IP when no mask_ip is defined (PR #3341)
From:       TorPetterson <notifications () github ! com>
Date:       2023-05-31 6:53:01
Message-ID: kamailio/kamailio/pull/3341/review/1452331422 () github ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


@TorPetterson commented on this pull request.



> @@ -92,11 +92,13 @@ modparam("topoh", "mask_key", "some secret here")
 		SIP URIs. Can be any IP address, even a private-space or non-existing
 		IP address (e.g., 192.168.1.1, 127.0.0.2), including the SIP server
 		address, but must not be an address potentially used by clients.
+		If not set, the advertised IP of the, incoming or outgoing, socket is used.

Is the new version better?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3341#discussion_r1211169188
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/pull/3341/review/1452331422@github.com>
[Attachment #5 (text/html)]

<p></p>
<p><b>@TorPetterson</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/3341#discussion_r1211169188">src/modules/topoh/doc/topoh_admin.xml</a>:</p>
 <pre style='color:#555'>&gt; @@ -92,11 +92,13 @@ modparam(&quot;topoh&quot;, \
&quot;mask_key&quot;, &quot;some secret here&quot;)  SIP URIs. Can be any IP address, \
even a private-space or non-existing  IP address (e.g., 192.168.1.1, 127.0.0.2), \
including the SIP server  address, but must not be an address potentially used by \
clients. +		If not set, the advertised IP of the, incoming or outgoing, socket is \
used. </pre>
<p dir="auto">Is the new version better?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br \
/>Reply to this email directly, <a \
href="https://github.com/kamailio/kamailio/pull/3341#discussion_r1211169188">view it \
on GitHub</a>, or <a \
href="https://github.com/notifications/unsubscribe-auth/ABO7UZIVOHOVTWLZQNDQZOLXI3TE3ANCNFSM6AAAAAAUGLLMJM">unsubscribe</a>.<br \
/>You are receiving this because you are subscribed to this thread.<img \
src="https://github.com/notifications/beacon/ABO7UZOIIXNURAQPQK72PILXI3TE3A5CNFSM6AAAA \
AAUGLLMJOWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTSWSDIZ4.gif" \
height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: \
none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; \
max-width: 0; max-height: 0; mso-hide: all">Message ID: \
<span>&lt;kamailio/kamailio/pull/3341/review/1452331422</span><span>@</span><span>github</span><span>.</span><span>com&gt;</span></span></p>
 <script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/3341#discussion_r1211169188",
"url": "https://github.com/kamailio/kamailio/pull/3341#discussion_r1211169188",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>



_______________________________________________
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-leave@lists.kamailio.org


[prev in list] [next in list] [prev in thread] [next in thread]