[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openser-devel
Subject:    Re: [sr-dev] [kamailio/kamailio] kamctl: enable kamctl test from shell variable. (#1977)
From:       Daniel-Constantin Mierla <notifications () github ! com>
Date:       2019-06-27 13:04:02
Message-ID: kamailio/kamailio/pull/1977/c506336830 () github ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


It seems that the issue is expanding the variable when getting the answer for y/n \
                question:
  * https://github.com/kamailio/kamailio/blob/master/utils/kamctl/kamdbctl.base#L216-L218


Such expression seems to be specific for bash:
  * https://mywiki.wooledge.org/Bashism

We should decide what to do to have an acceptable solution. Or maybe focus to make \
kamcli a (full) replacement for kamctl/kamdbctl and get rid of those old-style \
shell/bash scripts.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1977#issuecomment-506336830


[Attachment #5 (text/html)]

<p>It seems that the issue is expanding the variable when getting the answer for y/n \
question:</p> <ul>
<li><a href="https://github.com/kamailio/kamailio/blob/master/utils/kamctl/kamdbctl.ba \
se#L216-L218">https://github.com/kamailio/kamailio/blob/master/utils/kamctl/kamdbctl.base#L216-L218</a></li>
 </ul>
<p>Such expression seems to be specific for bash:</p>
<ul>
<li><a href="https://mywiki.wooledge.org/Bashism" \
rel="nofollow">https://mywiki.wooledge.org/Bashism</a></li> </ul>
<p>We should decide what to do to have an acceptable solution. Or maybe focus to make \
kamcli a (full) replacement for kamctl/kamdbctl and get rid of those old-style \
shell/bash scripts.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You \
are receiving this because you are subscribed to this thread.<br />Reply to this \
email directly, <a href="https://github.com/kamailio/kamailio/pull/1977?email_source=n \
otifications&amp;email_token=ABO7UZOTOZP5HYXXFTDP4CTP4S3EFA5CNFSM4HWQPIAKYY3PNVWWK3TUL \
52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYXBMPQ#issuecomment-506336830">view \
it on GitHub</a>, or <a \
href="https://github.com/notifications/unsubscribe-auth/ABO7UZK7VY3Y4N3SBUVJSADP4S3EFANCNFSM4HWQPIAA">mute \
the thread</a>.<img src="https://github.com/notifications/beacon/ABO7UZNEMPOWBHNPW7BO5 \
PTP4S3EFA5CNFSM4HWQPIAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYXBMPQ.gif" \
height="1" width="1" alt="" /></p> <script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1977?email_source=notifications\u \
0026email_token=ABO7UZOTOZP5HYXXFTDP4CTP4S3EFA5CNFSM4HWQPIAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYXBMPQ#issuecomment-506336830",
 "url": "https://github.com/kamailio/kamailio/pull/1977?email_source=notifications\u00 \
26email_token=ABO7UZOTOZP5HYXXFTDP4CTP4S3EFA5CNFSM4HWQPIAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYXBMPQ#issuecomment-506336830",
 "name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>


[Attachment #6 (text/plain)]

_______________________________________________
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


[prev in list] [next in list] [prev in thread] [next in thread]