[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openser-devel
Subject:    Re: [sr-dev] [kamailio/kamailio] Fix no cdr after restart (#1606)
From:       Daniel-Constantin Mierla <notifications () github ! com>
Date:       2018-07-27 12:57:00
Message-ID: kamailio/kamailio/pull/1606/c408410640 () github ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Thank for digging into it and coming with a fix.
Can you reformat the commit message so it matches the contributions guide:

  * https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#commit-message-format


So, the it should be like:

```
dialog: fix to get CDRs after restart

[more details here]
```

If you don't get the chance to do it soon, no worries, I can apply the patch \
manually, just have it in mind for future pull requests. It makes life easier by \
merging with one click here, instead of editing/patching source manually.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1606#issuecomment-408410640


[Attachment #5 (text/html)]

<p>Thank for digging into it and coming with a fix.<br>
Can you reformat the commit message so it matches the contributions guide:</p>
<ul>
<li><a href="https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md# \
commit-message-format">https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#commit-message-format</a></li>
 </ul>
<p>So, the it should be like:</p>
<pre><code>dialog: fix to get CDRs after restart

[more details here]
</code></pre>
<p>If you don't get the chance to do it soon, no worries, I can apply the patch \
manually, just have it in mind for future pull requests. It makes life easier by \
merging with one click here, instead of editing/patching source manually.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You \
are receiving this because you are subscribed to this thread.<br />Reply to this \
email directly, <a href="https://github.com/kamailio/kamailio/pull/1606#issuecomment-408410640">view \
it on GitHub</a>, or <a \
href="https://github.com/notifications/unsubscribe-auth/AF36ZS9G6gOeBnrrn2lkBBKsZLgbHb02ks5uKw4cgaJpZM4VjaFe">mute \
the thread</a>.<img src="https://github.com/notifications/beacon/AF36Ze4GNZ7MErIPVRftc4G5vrA7FZQcks5uKw4cgaJpZM4VjaFe.gif" \
height="1" width="1" alt="" /></p> <script type="application/json" \
data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384d \
d78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub \
repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards \
/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open \
in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miconda \
in #1606: Thank for digging into it and coming with a fix.\r\nCan you reformat the \
commit message so it matches the contributions guide:\r\n\r\n  * \
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#commit-message-format\r\n\r\nSo, \
the it should be like:\r\n\r\n```\r\ndialog: fix to get CDRs after \
restart\r\n\r\n[more details here]\r\n```\r\n\r\nIf you don't get the chance to do it \
soon, no worries, I can apply the patch manually, just have it in mind for future \
pull requests. It makes life easier by merging with one click here, instead of \
editing/patching source manually."}],"action":{"name":"View Pull \
Request","url":"https://github.com/kamailio/kamailio/pull/1606#issuecomment-408410640"}}}</script>
 <script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1606#issuecomment-408410640",
"url": "https://github.com/kamailio/kamailio/pull/1606#issuecomment-408410640",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [kamailio/kamailio] Fix no cdr after restart (#1606)",
"sections": [
{
"text": "",
"activityTitle": "**Daniel-Constantin Mierla**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
 "activitySubtitle": "@miconda",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \
\"kamailio/kamailio\",\n\"issueId\": 1606,\n\"IssueComment\": \
\"{{IssueComment.value}}\"\n}" }
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \
\"kamailio/kamailio\",\n\"pullRequestId\": 1606\n}" },
{
"targets": [
{
"os": "default",
"uri": "https://github.com/kamailio/kamailio/pull/1606#issuecomment-408410640"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 361603422\n}"
}
],
"themeColor": "26292E"
}
]</script>


[Attachment #6 (text/plain)]

_______________________________________________
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


[prev in list] [next in list] [prev in thread] [next in thread]