[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openser-devel
Subject:    [sr-dev] [kamailio/kamailio] ims_charging unlink_unsafe_ro_session (#1549)
From:       thulasizwe-n <notifications () github ! com>
Date:       2018-05-28 15:54:28
Message-ID: kamailio/kamailio/issues/1549 () github ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Apologies if i have not kept with the reporting standard.

Insertion attempts  of out-of-credit replies from resume_on_initial_ccr callback, are \
corrupting the ro_session list. i.e. they nullify the first and last fields, which \
under certain conditions the first entry gets restored but not the last.This then \
crashes the process at ro_session_hash.c (link_ro_session), where the first entry has \
                a valid address but the last does not.
Solution: ro_session_hash.h - unlink_unsafe_ro_session - check if the session  to be \
linked is actually part of list i.e

        if ((ro_session->next == 0x00) &&
        (ro_session->prev == 0x00) &&
        (ro_session != ro_session_entry->first) )
    {
                 ro_session, &(ro_session->ro_tl),
                 ro_session->callid.len,
                 ro_session->callid.len,
                 ro_session->callid.s);
        return;
    }
rest of the code ....

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1549


[Attachment #5 (text/html)]

<p>Apologies if i have not kept with the reporting standard.</p>
<p>Insertion attempts  of out-of-credit replies from resume_on_initial_ccr callback, \
are corrupting the ro_session list. i.e. they nullify the first and last fields, \
which under certain conditions the first entry gets restored but not the last.This \
then crashes the process at ro_session_hash.c (link_ro_session), where the first \
                entry has a valid address but the last does not.<br>
Solution: ro_session_hash.h - unlink_unsafe_ro_session - check if the session  to be \
linked is actually part of list i.e</p> <pre><code>    if ((ro_session-&gt;next == \
0x00) &amp;&amp;  (ro_session-&gt;prev == 0x00) &amp;&amp;
    (ro_session != ro_session_entry-&gt;first) )
{
             ro_session, &amp;(ro_session-&gt;ro_tl),
             ro_session-&gt;callid.len,
             ro_session-&gt;callid.len,
             ro_session-&gt;callid.s);
    return;
}
</code></pre>
<p>rest of the code ....</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You \
are receiving this because you are subscribed to this thread.<br />Reply to this \
email directly, <a href="https://github.com/kamailio/kamailio/issues/1549">view it on \
GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZUZIwxuu1IOYftN2wd4yxcGKAszJks5t3B20gaJpZM4UQYDY">mute \
the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZWjiotYD6qgX5ZvtNoxWsR9SUL2Cks5t3B20gaJpZM4UQYDY.gif" \
height="1" width="1" alt="" /></p> <script \
type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","pot \
entialAction":{"@type":"ViewAction","target":"https://github.com/kamailio/kamailio/issues/1549","url":"https://github.com/kamailio/kamailio/issues/1549","name":"View \
Issue"},"description":"View this Issue on \
GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
 <script type="application/json" \
data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384d \
d78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub \
repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards \
/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open \
in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"ims_charging \
unlink_unsafe_ro_session (#1549)"}],"action":{"name":"View \
Issue","url":"https://github.com/kamailio/kamailio/issues/1549"}}}</script> <script \
type="application/ld+json">{ "@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "37567f93-e2a7-4e2a-ad37-a9160fc62647",
"title": "ims_charging unlink_unsafe_ro_session (#1549)",
"sections": [
{
"text": "",
"activityTitle": "**thulasizwe-n**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
 "activitySubtitle": "@thulasizwe-n",
"facts": [
{
"name": "Repository: ",
"value": "kamailio/kamailio"
},
{
"name": "Issue #: ",
"value": 1549
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \
\"kamailio/kamailio\",\n\"issueId\": 1549,\n\"IssueComment\": \
\"{{IssueComment.value}}\"\n}" }
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \
\"kamailio/kamailio\",\n\"issueId\": 1549\n}" },
{
"targets": [
{
"os": "default",
"uri": "https://github.com/kamailio/kamailio/issues/1549"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 339837144\n}"
}
],
"themeColor": "26292E"
}</script>


[Attachment #6 (text/plain)]

_______________________________________________
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


[prev in list] [next in list] [prev in thread] [next in thread]